Various deps needed for tests are missing, so please add NO_TEST=Yes. otherwise LGTM
On 2024/05/15 19:45, Solene Rapenne wrote: > Changelog available https://github.com/jarun/buku/releases/tag/v4.9 > > works fine on amd64 > > I aligned a few variables to improve readability > > ok? > > diff --git a/www/buku/Makefile b/www/buku/Makefile > index 4b676574e3a..5c625039e65 100644 > --- a/www/buku/Makefile > +++ b/www/buku/Makefile > @@ -1,10 +1,9 @@ > -COMMENT = powerful command-line bookmark manager > +COMMENT = powerful command-line bookmark manager > > -MODPY_EGG_VERSION = 4.7.1 > -DISTNAME = buku-${MODPY_EGG_VERSION} > -REVISION = 2 > +MODPY_EGG_VERSION = 4.9 > +DISTNAME = buku-${MODPY_EGG_VERSION} > > -CATEGORIES = www > +CATEGORIES = www > > # GPLv3+ > PERMIT_PACKAGE = Yes > diff --git a/www/buku/distinfo b/www/buku/distinfo > index 8749c014b06..3244e48f028 100644 > --- a/www/buku/distinfo > +++ b/www/buku/distinfo > @@ -1,2 +1,2 @@ > -SHA256 (buku-4.7.1.tar.gz) = 5/OhAkpLkm5EgKMst5jwzjUBlh780VRCYWz+vrd3yRY= > -SIZE (buku-4.7.1.tar.gz) = 225845 > +SHA256 (buku-4.9.tar.gz) = e1NxoJYcbg2dEmoodMslrzOUv6i31EG8AWyFMyDj+mw= > +SIZE (buku-4.9.tar.gz) = 249347 > diff --git a/www/buku/pkg/PLIST b/www/buku/pkg/PLIST > index 522b4c846a0..a9d79e404c8 100644 > --- a/www/buku/pkg/PLIST > +++ b/www/buku/pkg/PLIST > @@ -18,6 +18,8 @@ > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}__init__.${M > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}__main__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}__main__.${MODPY_PYC_MAGIC_TAG}pyc > +lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}api.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > +lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}api.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}filters.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}filters.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}forms.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > @@ -28,26 +30,42 @@ > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}server.${MOD > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}server.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}views.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > > lib/python${MODPY_VERSION}/site-packages/bukuserver/${MODPY_PYCACHE}views.${MODPY_PYC_MAGIC_TAG}pyc > +lib/python${MODPY_VERSION}/site-packages/bukuserver/api.py > lib/python${MODPY_VERSION}/site-packages/bukuserver/filters.py > lib/python${MODPY_VERSION}/site-packages/bukuserver/forms.py > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/ > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/__init__.py > +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/${MODPY_PYCACHE}/ > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/${MODPY_PYCACHE}flask_reverse_proxy_fix.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION} > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/${MODPY_PYCACHE}flask_reverse_proxy_fix.${MODPY_PYC_MAGIC_TAG}pyc > +lib/python${MODPY_VERSION}/site-packages/bukuserver/middleware/flask_reverse_proxy_fix.py > lib/python${MODPY_VERSION}/site-packages/bukuserver/response.py > lib/python${MODPY_VERSION}/site-packages/bukuserver/server.py > lib/python${MODPY_VERSION}/site-packages/bukuserver/static/ > lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/ > +lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/css/ > +lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/css/bookmark.css > +lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/favicon.svg > lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/js/ > > lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/js/Chart.js > > lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/js/bookmark.js > +lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/js/last_page.js > +lib/python${MODPY_VERSION}/site-packages/bukuserver/static/bukuserver/js/page_size.js > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/ > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/ > -lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/base.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_create.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_create_modal.html > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_details.html > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_details_modal.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_edit.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmark_edit_modal.html > -lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmarks.html > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmarklet.url > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/bookmarks_list.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/home.html > -lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/index.html > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/lib.html > > lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/statistic.html > -lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/tags.html > +lib/python${MODPY_VERSION}/site-packages/bukuserver/templates/bukuserver/tags_list.html > lib/python${MODPY_VERSION}/site-packages/bukuserver/views.py > @man man/man1/buku.1 >