Here a reminder about this nice and small port, which needs the second ok.
On Thu, 02 May 2024 13:14:42 +0100,
Stuart Henderson <s...@spacehopper.org> wrote:
>
> On 2024/05/01 20:03, Kirill A. Korinsky wrote:
> > Anyone?
> >
> > On Thu, 25 Apr 2024 00:18:23 +0200,
> > Kirill A. Korinsky <kir...@korins.ky> wrote:
> > >
> > > [1 <text/plain; US-ASCII (7bit)>]
> > > Greetings,
> > >
> > > I'd like to offer a small python script which is called imapdedup. Idea of
> > > this script is remove duplicated emails from IMAP server.
> > >
> > > It has only one optional dependency: keyring.
> > >
> > > I use this script more than once.
> > >
> > > --
> > > wbr, Kirill
> > > [2 imapdedup.tgz <application/octet-stream (base64)>]
> >
> > --
> > wbr, Kirill
> >
>
> I think it's OK with this on top:
>
> - some whitespace nits ("FOO=" vs "FOO =")
>
> - it doesn't use the normal Python build mechanisms so shouldn't use the
> MODPY_PYBUILD (you can set CONFIGURE_STYLE=none to workaround the python
> module trying to run setup.py) or MODPY_EGG_VERSION
>
> - use MODPY_ADJ_FILES rather than a handrolled implementation
>
> - use a PKGNAME version that will allow using an upstream version number
> directly if they change to providing releases sometime
>
> diff --git mail/imapdedup/Makefile mail/imapdedup/Makefile
> index 3849a0f..f1334c0 100644
> --- mail/imapdedup/Makefile
> +++ mail/imapdedup/Makefile
> @@ -1,9 +1,8 @@
> COMMENT = IMAP message de-duplicator
>
> V = b232a13bf923292dccb0dd22a78b74e20950daf3
> -MODPY_EGG_VERSION= 20240131
>
> -PKGNAME = imapdedup-${MODPY_EGG_VERSION}
> +PKGNAME = imapdedup-0.0.20240131
>
> DIST_TUPLE += github quentinsf IMAPdedup ${V} .
>
> @@ -14,19 +13,15 @@ HOMEPAGE =
> https://quentinsf.com/software/imapdedup
> # GPLv2+
> PERMIT_PACKAGE= Yes
>
> -MODULES= lang/python
> -
> -MODPY_PI= no
> -MODPY_PYBUILD = other
> +MODULES = lang/python
> +MODPY_ADJ_FILES = imapdedup.py
> +CONFIGURE_STYLE = none
>
> RUN_DEPENDS= security/py-keyring${MODPY_FLAVOR}
>
> NO_BUILD = Yes
> NO_TEST = Yes
>
> -pre-configure:
> - ${SUBST_CMD} ${WRKSRC}/imapdedup.py
> -
> do-install:
> ${INSTALL_SCRIPT} ${WRKSRC}/imapdedup.py ${PREFIX}/bin/imapdedup
> ${INSTALL_DATA} ${WRKSRC}/README.md ${PREFIX}/share/doc/imapdedup
>
--
wbr, Kirill
