Le Tue, Apr 23, 2024 at 02:20:21PM +0100, Stuart Henderson a écrit : > On 2024/04/23 10:29, Landry Breuil wrote: > > Le Sun, Apr 21, 2024 at 10:17:44PM +0200, Frederic Cambus a écrit : > > > On Fri, Apr 19, 2024 at 05:50:09AM +0200, Landry Breuil wrote: > > > > > > > this is a second attempt at a port for https://lnav.org, after > > > > https://marc.info/?t=153339681200002&r=1&w=2 some years ago, which > > > > fcambus@ reminded me about. He pushed it to wip but had issues with it > > > > linking against two readline libs. > > > > > > Thanks for picking this up again! > > > > > > > i had originally put it under textproc/ but frederic had it in > > > > sysutils/, no strong opinion on that. > > > > > > FWIW both FreeBSD and NetBSD have it in sysutils, but no strong opinion > > > either. > > > > > > > the attached port links against only one readline (the one from ports), > > > > and i've tried to do my best to have tests running. For now it seems one > > > > hangs.. > > > > > > > > PASS: lnav_doctests > > > > PASS: test_abbrev > > > > PASS: test_ansi_scrubber > > > > PASS: test_auto_fd > > > > PASS: test_auto_mem > > > > PASS: test_bookmarks > > > > ../test-driver: line 112: 69425 Abort trap (core dumped) > > > > "$@" >> "$log_file" 2>&1 > > > > FAIL: test_date_time_scanner > > > > PASS: test_format_installer.sh > > > > <stuck> > > > > > > > > in 0.12.1 a PRQL feature was added > > > > (https://github.com/tstack/lnav/commit/bdc9c5a28d8308a53ba4f881b29c307cff7cd97a) > > > > but it relies on rust/cargo being run from gmake and at that point i've > > > > just disabled this feature. > > > > > > Makes sense, yes. > > > > > > > feedback & testing welcome > > > > > > The build fails at link time if devel/fmt is installed. > > > > i've tried it, and with fmt 10.2.1 installed the build doesnt fail. when > > you saw that failure i suppose that was with the previous fmt version > > installed ? > > It's preferring libfmt in /usr/local for headers in some of the compiler > commands lines - "-I/usr/local/include -I./.. -I./../fmtlib" - so even > if it works now, things will likely break again in the future. > > It would be best to figure out how to get the -I reordered so that > -I./../fmtlib comes before -Iusr/local/include. You can check by > installing fmt, editing /usr/local/include/fmt/format.h to add a > #error at the top, and make sure that lnav still builds.
this version builds fine with a poisoned fmt/format.h $grep \#error /usr/local/include/fmt/format.h #error lnav/patches/patch-src_tailer_Makefile_in just reorders the includes as advised, and it works fine. i've cleaned up makefile, tests still hang but some of them run fine, there's still room from improvement here so i've left NO_TEST commented out - but at least it now runs, even producing some NULL vfprintf on the way :) Apr 24 09:07:30 c64 lnav: vfprintf %s NULL in " XDG_CONFIG_HOME=%s" Apr 24 09:07:30 c64 lnav: vfprintf %s NULL in " TZ=%s" Apr 24 09:07:31 c64 lnav: vfprintf %s NULL in "read next header %s %s" Landry
lnav-0.12.1_2.tgz
Description: application/tar-gz
