James Cook <falsif...@falsifian.org> writes: > The line you linked to comes after a check for cpuid_bit::osxsave, > so I don't think it would get reached on machines that don't have > xgetbv, i.e. it should be fine.
Cool, so maybe we need a patch which does this? I also just noticed that you patched libraries/text/cbits/measure_off.c whereas I was looking at libraries/text/simdutf/simdutf.h hence my confusion. The latter is shipped disabled, so we don't have to keep patching it: https://gitlab.haskell.org/ghc/ghc/-/blob/master/hadrian/src/Settings/Packages.hs#L197 > Similarly, the existing patch-libraries_text_simdutf_simdutf_h in > ports doesn't seem to cause a problem with my AMD machine. At least, > now I have pandoc working; not sure if I actually exercised that code > in simdutf.h. Yeah, looks like this is dead code from our POV. > If it would help, I could update my old AMD machine to -current > and check ghc works with the two patches removed, once I've finished > trying out the patch I just sent for 7.5. Thanks James for working through this. Yes, we need the new development to happen on -current ports with -current base system. We'd also want a more complicated patch than the one you just sent because base supports avx-512 now. https://codeberg.org/openbsd/src/commit/c0f33c9875c4ab47e986b698610630b6cbf21c6c Thanks Greg
