On Wed, 06 Mar 2024 16:42:51 +0100 Omar Polo <o...@omarpolo.com> wrote:
> Hello, > > On 2024/03/04 22:38:23 +0000, Klemens Nanni <k...@openbsd.org> wrote: > > On Mon, Mar 04, 2024 at 05:21:52PM -0500, Stefan Moran wrote: > > > Attached is a port for www/pipe-viewer 0.5.0, a lightweight perl > > > youtube client, designed to be used without a Google API key. The > > > port is a multipackage with -gtk, a GTK3 frontend using > > > x11/p5-Gtk3, and -main, the standard cli interface. The port > > > depends on either youtube-dl or yt-dlp to fetch videos, and I > > > chose to include www/yt-dlp as a rundep as that seems to be the > > > more heavily-maintained and functional ( and also less > > > legally-targeted ;) ) project at this point in time. I also chose > > > to include most of the optional dependencies, excluding > > > LWP::UserAgent::Cached (not currently ported). > > > > > > https://github.com/trizen/pipe-viewer > > > > Port-wise looks fine, although I'd capitalise youtube in COMMENT > > accordingly and distinguish DESCR-gtk from DESCR-main. > > Perhaps add multimedia, net and/or x11 to CATEGORIES? > > +1 > > I'd also try to have a slightly different COMMENT for the -gtk > subpackage and change its name to gkt-pipe-viewer to mirror the name > of the binary it installs. > > When it makes sense, I think it's easier for discovery purposes to > have the name of the package to be the same of the program it > installs. > > > Starts, searches and plays fine in brief testing, seems like a handy > > alternative to the (heavy) Qt alternatives minitube and plasmatube. > > > > some here, briefly tried but I'm liking it, it could become my > preferred way to navigate youtube :) > > I'm attaching a diff against your makefile and an updated tarball > that's ok op@ to import. > > while here i've changed to port to use DIST_TUPLE rather than GH_* and > re-run make makesum due to it. I've also tried to change the two > DESCR a bit, to reiterate which one has a GTK interface and which > don't. > > > --- Makefile.orig Wed Mar 6 15:02:57 2024 > +++ Makefile Wed Mar 6 16:33:07 2024 > @@ -1,17 +1,14 @@ > -COMMENT-main = lightweight perl youtube client > -COMMENT-gtk = lightweight perl youtube client > +COMMENT-main = lightweight YouTube client > +COMMENT-gtk = lightweight YouTube client with a GTK interface > > VERSION = 0.5.0 > +DIST_TUPLE = github trizen pipe-viewer ${VERSION} . > PKGNAME-main = pipe-viewer-${VERSION} > -PKGNAME-gtk = pipe-viewer-gtk-${VERSION} > +PKGNAME-gtk = gtk-pipe-viewer-${VERSION} > > MULTI_PACKAGES = -main -gtk > > -GH_ACCOUNT = trizen > -GH_PROJECT = pipe-viewer > -GH_TAGNAME = ${VERSION} > - > -CATEGORIES = www > +CATEGORIES = www multimedia Patch and suggested changes look good to me, only thing I'm a bit skeptical about is the multimedia tag, since this port just calls on external rundeps (mpv, youtube-dl/yt-dlp) to fetch and playback streams, and doesn't really do anything I'd classify as multimedia itself. www/minitube does something similar to this port, and is also tagged multimedia though, so maybe this port should be tagged multimedia too just for consistency. > > MAINTAINER = Stefan Moran <s...@howdoesmycode.work> > >
