> From: Jeremie Courreges-Anglas <j...@wxcvbn.org> > Date: Mon, 19 Feb 2024 23:34:34 +0100 > > On Mon, Feb 19 2024, Mark Kettenis <mark.kette...@xs4all.nl> wrote: > > This will be used in an upcoming u-boot update for Allwinner's 64-bit > > SoCs. This will bring "proper" S3-like suspend/resume on selected > > boards. > > > > ok? > > Please see nits below. > > > > > diff --git a/sysutils/crust/Makefile b/sysutils/crust/Makefile > > new file mode 100644 > > index 00000000000..3b187598161 > > --- /dev/null > > +++ b/sysutils/crust/Makefile > > @@ -0,0 +1,57 @@ > > +PKG_ARCH= * > > + > > +COMMENT= Libre SCP firmware for Allwinner sunxi SoCs > > Should start lowercase unless for a good reason (eg acronyms). Here > I think "libre" is more appropriate. > > > +GH_ACCOUNT= crust-firmware > > +GH_PROJECT= crust > > +GH_TAGNAME= v0.6 > > + > > +CATEGORIES= sysutils > > + > > +# BSD > > +PERMIT_PACKAGE= Yes > > + > > +BUILD_DEPENDS+= devel/or1k-elf/gcc > > > +MAKE_ENV+= CROSS_COMPILE="or1k-unknown-elf-" > > I know it's done in a lot of places, but "+=" is not useful here, please > just use "=". > > Also: > - space vs tab for the MAKE_ENV line > - keeping VAR= VALUE aligned makes things more readable > > Adding > MAKE_FLAGS= V=1 > lets us see the flags used for compilation. > > Diff to previous below, and updated tarball attached. > Please submit tarballs for new ports! ;)
Only as tarballs? Or both tarballs and diffs? > ok jca@ to import Thanks!
