izder456 writes: > I want to import melonDS. It is a Nintendo DS emulator that boasts > better performance, and emulated networking support, and other things.
Thanks, this will be a good port to have. > I had to disable JIT unfortunately, it refused to build with it on. It's trying to grab the pc register from context structs... possibly there's a way to get this to build, but I'm happy without the JIT. > Otherwise- performance is mostly alright for me (Only tested Real dumps > of my Animal Crossing Wild World and Mario Kart DS cartridges). > > other testing before merge would be appreciated. I have a big list of mostly minor revisions. - Missing dep on extra-cmake-modules. - make port-lib-depends-check reveals several missing libs, and BUILD_DEPENDS that should be LIB_DEPENDS. - make update-patches gives different names to the patch files. - Lowercase package name. - HOMEPAGE can be switched to https. - Indentation is a bit wide, looks like 4-space tabs instead of 8-space? - Readme can be removed. The JIT note is not really important, and since 0.9.4 melonDS hasn't required firmware dumps. - DESCR also mentions the outdated firmware requirement. - No need to set NO_TESTS, because 'make test' doesn't error out. That malloc patch is correct; please push it upstream. I went ahead and reformatted the port to fix the issues listed above. Update is attached. ok to import? -- Anthony J. Bentley
melonds.tar.gz
Description: melonds.tar.gz
