On 2024/02/16 21:41:25 -0500, George Koehler <kern...@gmail.com> wrote:
> On Fri, 16 Feb 2024 13:47:13 -0500
> Jag Talon <jag@aangat.lahat.computer> wrote:
>
> > Here's the new attachment. Thank you!
>
> Yes, it runs on macppc, but it feels slow (but still usable) on my
> 750 MHz 1-core PowerPC G4. If I type in a field, the wait is about
> 1/2 second until I see the character. If I draw a curve with the
> pencil, a gap forms between the curve and my mouse cursor. When I am
> idle (staring at a new deck), the cpu usage in top(1) is near 50%.
> (Idle cpu usage for lang/pcbasic is 20%, for emacs--gtk3 is 0%.)
>
> I have 2 concerns about the port,
>
> 1. The '$ firefox /usr/local/share/doc/decker/' in pkg/README is
> probably wrong, as Omar Polo said yesterday. Your README
> doesn't need to mention these html docs. (Other ports, like
> cmake and gettext, install html docs, but have no port README.)
> If you do want to mention the html docs, then you don't need to
> provide a command to read them.
>
> 2. The 'MAKE_ENV = COMPILER="${CC}"' looks wrong, because the
> WRKSRC/Makefile's COMPILER=clang overrides it. See 'man make',
> "The four different classes of variables". A build on sparc64
> (or whichever arch lacks clang) might fail. You already have
> a patch-Makefile so I suggest to patch the COMPILER line.
Ooops, this is my bad, I meant to use MAKE_FLAGS. I did it before
realizing that we still need to patch the makefile anyway.
