On Wed, Feb 14, 2024 at 07:27:11PM +0100, Omar Polo wrote:
> then, some comments about the port.
+1
> - why removing the *la files?
A bunch of ports do this, not sure why, though.
deadbeef's builtin plugins also come without .la files.
> I'm attaching an updated ports and a diff against your makefile. The
> port looks fine to me now, but as I don't use deadbeef I haven't gone
> further than `make package'.
License marker "GPLv2" would be consistent with ports.
devel/libtool is automatically added as BDEP and can be dropped.
Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2?
Not sure it matters much, but seems simpler and less confusing without.
Took me a while to find out that deadbeef defaults to the null audio output
and I had to select PulseAudio to hear something, but after that using
playerctl to contol volume and playback just worked.
> --- Makefile.orig Wed Feb 14 18:49:28 2024
> +++ Makefile Wed Feb 14 19:15:33 2024
> @@ -1,13 +1,11 @@
> COMMENT = deadbeef plugin for mpris2 support
>
> -V = 1.16
> +V = 1.16
> DIST_TUPLE += github DeaDBeeF-Player deadbeef-mpris2-plugin v${V} .
> PKGNAME = deadbeef-plugin-mpris2-${V}
>
> CATEGORIES = audio
>
> -HOMEPAGE =
> https://github.com/DeaDBeeF-Player/deadbeef-mpris2-plugin
> -
> MAINTAINER = izzy Meyer <izder...@disroot.org>
>
> # GPL v2 only
> @@ -16,30 +14,25 @@
> WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0
> WANTLIB += pthread iconv intl pcre2-8 z ffi
>
> -COMPILER = base-clang ports-gcc
> -
> -
> -LIB_DEPENDS = devel/pcre2
> -BUILD_DEPENDS = devel/libtool \
> - devel/libffi \
> - devel/pcre2
> +LIB_DEPENDS = devel/glib2 \
> + devel/libffi \
> + devel/pcre2
> +BUILD_DEPENDS = audio/deadbeef \
> + devel/libtool
> RUN_DEPENDS = audio/deadbeef
>
> CONFIGURE_STYLE = autoreconf
>
> -CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include \
> - -I${X11BASE}/include' \
> - LDFLAGS='-L${LOCALBASE}/lib
> -L${X11BASE}/lib' \
> +CPPFLAGS += -I${LOCALBASE}/include \
> + -I${X11BASE}/include
> +LDFLAGS += -L${LOCALBASE}/lib \
> + -L${X11BASE}/lib
> +CONFIGURE_ENV += CPPFLAGS='${CPPFLAGS}' \
> + LDFLAGS='${LDFLAGS}'
>
> -CONFIGURE_ARGS = --prefix ${LOCALBASE} \
> - --disable-static
> -
> LIBTOOL_FLAGS = --tag=disable-static
>
> -AUTOCONF_VERSION = 2.69
> +AUTOCONF_VERSION = 2.71
> AUTOMAKE_VERSION = 1.16
> -
> -post-install:
> - @rm ${PREFIX}/lib/deadbeef/*.la
>
> .include <bsd.port.mk>
>
>
