El Tue, 13 Feb 2024 17:58:36 -0500
Thomas Frohwein <tfrohw...@fastmail.com> escribió:
> On Mon, Feb 12, 2024 at 01:51:30PM -0400, Jose Maldonado wrote:
> >
> > Hello everyone!
> >
> > This is an update for libplacebo. Our port version (v4.208.0) is
> > already two years old and we already have to make a small bump due
> > to the arrival of a new mpv (v0.37.0).
> >
> > This new version of libplacebo requires a series of additional
> > dependencies that I have submitted as new ports to the list:
> > devel/fast-float and graphics/glad.
> >
> > With this new version and its dependencies we can activate support
> > for Vulkan and OpenGL in the library, aiming to take advantage of
> > these capabilities.
> >
> > In the future, when we have Mesa-23.2.1 and ffmpeg-6.1 on OpenBSD,
> > perhaps we can take advantage of the ability of ffmpeg, mpv, and
> > libplacebo to obtain hwaccel through Vulkan (for h264, h265 and AV1,
> > without needing go through VAAPI). For now, the latter is in the
> > future, it will depend on our versions of Mesa and ffmpeg, along
> > with the appropriate support.
>
> Thanks for the diff, a few comments below inline and then an updated
> diff from me attached. Please remember to CC maintainer as they may
> not always be subscribed to ports@.
>
> Also important to know if ports that depend on the library have been
> tested with the new version, and if any of them might need an update
> with the API changes. I can find only mpv and vlc when looking at
> WANTLIBs in sqlports, and I rebuilt mpv and it still works FWIW.
>
> There was trailing whitespace - it's generally recommended to run
> portcheck(1) (in /usr/ports/infrastructure/bin/) which will catch that
> (among other things).
>
> [...]
>
> > MAINTAINER= Brad Smith <b...@comstyle.com>
>
> [...]
>
> > -WANTLIB= epoxy execinfo lcms2 m pthread
> > +WANTLIB+= ${COMPILER_LIBCXX} epoxy execinfo GL lcms2 m
> > pthread +WANTLIB+= shaderc_shared vulkan
>
> $ make port-lib-depends-check
>
> libplacebo-6.338.2(graphics/libplacebo):
> Extra: GL.19 epoxy.4
>
> I assume these 2 libraries are dlopen'd? In that case it would be
> preferable to add a comment about this above the WANTLIB block.
>
> > MODULES= devel/meson
> >
> > -LIB_DEPENDS= graphics/lcms2
> > +BUILD_DEPENDS= devel/fast-float \
> > + graphics/glad \
> > + graphics/shaderc \
>
> A LIB_DEPENDS is automatically also a BUILD_DEPENDS, so no need to
> list shaderc here. (see bsd.port.mk(5))
>
> > + graphics/vulkan-headers \
>
> I would avoid dangling '\' at the end.
>
> > +LIB_DEPENDS= graphics/lcms2 \
> > + graphics/shaderc
> > +
> > +RUN_DEPENDS= graphics/vulkan-loader
>
> ===> Verifying specs: [...] Missing library for vulkan>=0.0
>
> vulkan-loader needs to be LIB_DEPENDS given the WANTLIB entry.
>
> Hi Thomas! Following your recommendations I send you the revised diff for libplacebo. I have put it through portcheck and without problems. I've also followed your recommendations for the new mpv, so I'll post the new diff in that thread. -- ********************************************************* Dios en su cielo, todo bien en la Tierra
libplacebo_6_338_2
Description: Binary data
