On Mon, Feb 12, 2024 at 09:47:55PM +0100, Martijn van Duren wrote:
[...]
> > - drop devel/sdl2 LDEP (is pulled in by sdl2-mixer and sdl2-image)
> > -> same for audio/libogg
>
> If they're direct dependencies tested for by the configure script,
> shouldn't they be explicitly noted?
I don't think so; there is precedent in other ports where we leave out
sdl2 because 1+ of the other sdl2-* that depend on it is already
included.
[...]
> > - disable doxygen? (low quality docs; don't set ENABLE_DOC)
>
> I haven't really looked at the output of doxygen. But the doxygen
> part is needed to install the manpage. This can of course be done
> with a workaround, but didn't thought it'd be the effort compared to
> this flag.
I didn't see the manpage parts, either way is fine with me.
> > - add archivers/innoextract to RDEP? (see patches - this is used by runtime)
>
> I've added these to war{,1}gus, since it's in the code that's in the
> .h files (yes... I know...), so it's war{,1}gus binary that calls this
> function and not the stratagus binary. But there's something to say to
> let stratagus have the dependency since it's its header... I'll change
> it if you still feel it's in the wrong place as is.
That makes sense, I think you can leave it as it is then.
> > - variables USE_OPENMP and USE_BACKTRACE are not used by cmake (see
> > make configure output)
> >
> You're right. USE_OPENMP was needed for the head of tree, apparently
> it detects it correct in the release. Same for USE_BACKTRACE.
I just grep'd through the port. USE_BACKTRACE doesn't show up at all.
USE_OPENMP appears to be a compiler definition (not for cmake) and is
set automatically _by_ cmake if it finds OpenMP_CXX.
> > $ make show=MODCMAKE_BUILD_TARGET
> > cd /usr/ports/pobj/stratagus-3.3.2/build-amd64 && exec /usr/bin/env -i
> > MODCMAKE_USE_SHARED_LIBS=yes MODCMAKE_PORT_BUILD=yes PORTSDIR="/usr/ports"
> > LIBTOOL="/usr/bin/libtool"
> > PATH='/usr/ports/pobj/stratagus-3.3.2/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11R6/bin'
> > PREFIX='/usr/local' LOCALBASE='/usr/local' X11BASE='/usr/X11R6'
> > CFLAGS='-O2 -pipe' TRUEPREFIX='/usr/local' DESTDIR=''
> > HOME='/stratagus-3.3.2_writes_to_HOME' PICFLAG="-fpic" BINGRP=bin
> > BINOWN=root BINMODE=755 NONBINMODE=644 DIRMODE=755 INSTALL_COPY=-c
> > INSTALL_STRIP=-s MANGRP=bin MANOWN=root MANMODE=644
> > BSD_INSTALL_PROGRAM="/usr/ports/pobj/stratagus-3.3.2/bin/install -c -s -m
> > 755" BSD_INSTALL_SCRIPT="/usr/ports/pobj/stratagus-3.3.2/bin/install -c -m
> > 755" BSD_INSTALL_DATA="/usr/ports/pobj/stratagus-3.3.2/bin/install -c -m
> > 644" BSD_INSTALL_MAN="/usr/ports/pobj/stratagus-3.3.2/bin/install -c -m
> > 644" BSD_INSTALL_PROGRAM_DIR="/usr/ports/pobj/stratagus-3.3.2/bin/install
> > -d -m 755"
> > BSD_INSTALL_SCRIPT_DIR="/usr/ports/pobj/stratagus-3.3.2/bin/install -d -m
> > 755" BSD_INSTALL_DATA_DIR="/usr/ports/pobj/stratagus-3.3.2/bin/install -d
> > -m 755" BSD_INSTALL_MAN_DIR="/usr/ports/pobj/stratagus-3.3.2/bin/install
> > -d -m 755" cmake --build /usr/ports/pobj/stratagus-3.3.2/build-amd64
> > --verbose -j 1
> >
> Not quite sure what you're trying to show here. Sorry.
I put this in here in the hope someone with the necessary cmake
knowledge could spot which part of our build target leads to the
different behavior from cmake without any of these env vars and
arguments...
>
> > > One issue is that sound doesn't play with video cut scenes and is
> > > something that boils up from SDL2's Mix_LoadMUS or Mix_LoadMUS_RW in
> > > stratagus' src/sound/sound_server.cpp's LoadMusic().
> > >
> > > martijn@
> >
> >
>
