On 2024/01/31 18:04:16 +0100, Giovanni Bechis <giova...@openbsd.org> wrote: > On 1/30/24 17:02, Omar Polo wrote: > > This should make opensmtpd-extras work with a future imsg.fd removal. > > > > m_forward() is not used at all in -extras, so I could have also used -1 > > there, it doesn't matter. > > > > The queues are doing imsg passing, so the second hunk is actually > > needed, even if I doubt anyone is using them? anyway, the diff is > > simple enough that I'm confident I'm not breaking anything. > > > > There is still one hit of 'imsg->fd' in api/filter_api.c, but that file > > is not used anymore, and so I haven't touched it. > > The diff makes sense, the diff should also be committed upstream. > ok giovanni@
I've committed it, thanks. For upstream things are a bit more difficult as the whole compat layer needs to be updated as well. Meanwhile I'm resurrecting with gilles the idea of using a filter-like text protocol for tables too which should make all this imsg handling redundant, so unless things breaks I'd propend to not touch upstream in this regard.
