On Wednesday, January 10th, 2024 at 03:12, A Tammy <openbsd.po...@aisha.cc> wrote:
> On 1/9/24 09:32, Mina Galić wrote: > > > > Could you provide a tarball with the new port? > > > Tarball is attached. > > > > I've also updated my Git repo: > > > > browse: > > https://codeberg.org/meena/openbsd-ports/src/branch/add/cloud-init/sysutils/cloud-init > > > > browse patch: > > https://codeberg.org/meena/openbsd-ports/commit/df1e11cdb40ca0120c1d291f5e4f0058729fa8c6 > > > > Apply patch: > > https://codeberg.org/meena/openbsd-ports/commit/df1e11cdb40ca0120c1d291f5e4f0058729fa8c6.patch > > > > Kind regards, > > > > Some initial comments. > > At least TEST_DEPS need security/py-passlib and devel/py-serial done. > pkg/README can has hardcoded paths, which can be changed to SYSCONFDIR > and LOCALSTATEDIR. that's an optimistic assessment cloud-init's build system. our setup.py is a pile of hacks, organically grown into the mess that it is today. > The build system for python can probably be set to use > MODPY_BUILD=setuptools instead of MODPY_SETUPTOOLS=Yes tried it, it doesn't work. > Am getting the following test failures on my machine: SNIP > = 21 failed, 5010 passed, 11 skipped, 1 xfailed, 2225 warnings in And that's just 21! When I started my work, we had about 200 test failures on FreeBSD. I've managed to cut those down to zero. Well, once my python patches get merged to our port. I'll try to get this down further for OpenBSD. > They seem to be related to hot-attaching a NIC and some Azure related > errors. Both of which don't seem super relevant to openbsd. Yeah, the easiest way to fix these tests will be to skip them on platforms that don't support netlink. > I also see that a lot example template files are not making it into the > package PLIST. SNIP > You could potentially move them to > /usr/local/share/doc/cloud-init/templates in a post-install step, that > way the user gets the templates somewhere in the system and they can > choose when to use them. This is a misconception of what the templates are: The user doesn't choose to use them. The user doesn't modify them. The software needs them. But, yeah, /usr/local/share/ might make more sense. We could also do what Alpine does, and remove the ones irrelevant to the platform: https://git.alpinelinux.org/aports/tree/community/cloud-init/APKBUILD#n133 > Cheers, > Aisha Thanks for the feedback, Mina http://www.unicode-symbol.com/u/0107.html Galić
