On 2024/01/06 23:28, artsi0m wrote:
> Hello there, that my initial patches[5] for port of py3-bdfparser --
> python library for parsing file format of bdf fonts.
>
> First of all, thanks for creating python-module(5) and py-cparser port
> from which I copied almost all.
>
> Paragraph about why I need this: So, Jon[1] saw me responding to
> question about wpa_supplicant port on mailing-list. He send me link to
> his server with archive[2] that contains python script bdf2wscons.py
> As he said: "This python script takes bdf fonts and generates a wsfont
> compatible header file, along with the code to put in wsfont.c" But
> this script depends on bdfparser python package, that can be installed
> using pip. I thought that using pkg_add or make install would be more
> handy for someone.
>
> Combining results of this script with some exoticsilicon[3] patches,
> and some more changed of wsfont.c you can enable wsconsole to display
> scripts thats are part of utf8(7) plane, but not of the ascii(7), so
> cyrillic and\or japanese characters and much more.
>
> Jon said, that he would like to write an tutorial about that and we
> asked owner of openbsd_ru community repo[4] for permission to publish
> article in english. He said Ok. We decided that I and some more
> members of our community can test it and then translate to Russian.
> Owner of openbsd.org.ru already responded with the mail with attached
> screenshot of succesfully executed instruction from Jon.
>
> Paragraph on maintainership:
> I remember that it was written somewhere, that the new ports should
> have an maintainer mentioned in Makefile. It would be ok, if someone
> with commit bit would write my email there, I just didn't done this
> myself, because currently I am studying at Belarussian University of
> Informatics and Radioelectronics and I am not sure that I will have a
> lot of time to spend until graduation.
>
> Frankly speaking that also the reason why I am using gmail and
> cyrillic characters in place in front of address sometimes,
> I was asked to do so.
>
> Also sorry for spending your time on reading such a long
> message, I just wanted my patches being accepted, if you don't like
> formating I can respond with a link to github repo.
> Best regards, Artsiom.
>
> [1]: mailto:jon@elytron.openbsd.amsterdam
> [2]: https://elytron.openbsd.amsterdam/wsfontgen.tar.gz
> [3]: https://research.exoticsilicon.com/
> [4]: https://openbsd-ru.github.io
> [5]: Below, generated with git --relative .
> ---
> Makefile | 16 ++++++++++++++++
> distinfo | 2 ++
> pkg/DESCR | 6 ++++++
> pkg/PLIST | 14 ++++++++++++++
> 4 files changed, 38 insertions(+)
> create mode 100644 devel/py3-bdfparser/Makefile
> create mode 100644 devel/py3-bdfparser/distinfo
> create mode 100644 devel/py3-bdfparser/pkg/DESCR
> create mode 100644 devel/py3-bdfparser/pkg/PLIST
>
> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..ce926fd
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,16 @@
> +COMMENT= BDF format bitmap font file parser library in Python
> +
> +MODPY_EGG_VERSION= 2.2.0
> +DISTNAME= bdfparser-${MODPY_EGG_VERSION}
> +PKGNAME= ${DISTNAME:S/py/py-/}
This tries to replace "py" with "py-" from DISTNAME, but there is
no py in DISTNAME. I think it should just use
PKGNAME= py-${DISTNAME}
> +CATEGORIES= devel
devel is quite a busy category and it's usually better to choose another
if possible. I think perhaps graphics might be better (or maybe even
sysutils).
Please add a HOMEPAGE, I think either https://font.tomchen.org/bdfparser_py/
or https://github.com/tomchen/bdfparser would do.
> +
> +# MIT
> +PERMIT_PACKAGE= YES
> +
> +MODPY_PI= Yes
> +MODPY_PYBUILD= setuptools
> +
> +MODULES= lang/python
> +
> +.include <bsd.port.mk>
> diff --git a/distinfo b/distinfo
> new file mode 100644
> index 0000000..0673580
> --- /dev/null
> +++ b/distinfo
> @@ -0,0 +1,2 @@
> +SHA256 (bdfparser-2.2.0.tar.gz) =
> dc69fC8e1eXQmFdjslVyapU4xgLHxcqGOXB67FSlhoM=
> +SIZE (bdfparser-2.2.0.tar.gz) = 14631
> diff --git a/pkg/DESCR b/pkg/DESCR
> new file mode 100644
> index 0000000..d03be08
> --- /dev/null
> +++ b/pkg/DESCR
> @@ -0,0 +1,6 @@
> +BDF format bitmap font file parser library in Python. It has Font,
> +Glyph and Bitmap classes providing more than 30 chainable API methods
> +of parsing BDF fonts, getting their meta information, rendering text
> +in any writing direction, adding special effects and manipulating
> +bitmap images. It works seamlessly with PIL / Pillow and NumPy, and
> +has detailed documentation / tutorials / API reference.
> \ No newline at end of file
Should have a newline at end of file.
The rest looks good, so with those changes I'd give an ok for someone to
import it.
If possible we would prefer an attached tar.gz for new ports; applying
git diffs to a cvs tree for import is a bit of a pain.
> diff --git a/pkg/PLIST b/pkg/PLIST
> new file mode 100644
> index 0000000..25023b4
> --- /dev/null
> +++ b/pkg/PLIST
> @@ -0,0 +1,14 @@
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/LICENSE
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/METADATA
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/RECORD
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/WHEEL
> +lib/python${MODPY_VERSION}/site-packages/bdfparser-${MODPY_EGG_VERSION}.dist-info/top_level.txt
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/__init__.py
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/bdfparser/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/${MODPY_PYCACHE}bdfparser.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/${MODPY_PYCACHE}bdfparser.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/bdfparser/bdfparser.py
> --
> 2.43.0
>
