On Mon Dec 18, 2023 at 10:08:14AM +0000, Stuart Henderson wrote: > On 2023/12/18 01:39, Rafael Sadowski wrote: > > Here is a cmake update diff to version 3.28.1. > > > > Upstream fixed shared libraries detection on OpenBSD[1]. I can't predict > > the impact but a handful of cmake ports build,packaged fine with that > > update. > > > > 1: https://gitlab.kitware.com/cmake/cmake/-/issues/12954 > > Is that correct? That ticket was closed 7 years ago with no information, > and nothing in changelog seems relevant?
Oh thanks Stuart! I was already wondering. Yes, that's 11 years old: https://gitlab.kitware.com/cmake/cmake/-/commit/afc75bb7f520b7405a08f24a25a42542d3e3c92f > > > Could someone push it into the next build arm64 or amd64. > > > > Thanks Rafael > > > > The changelog you can find here: > > https://cmake.org/cmake/help/v3.28/release/3.28.html > > https://cmake.org/cmake/help/v3.28/release/3.28.html#id1 > > This one seems likely to cause some issues: > > "The exec_program() command, which has been deprecated since CMake 3.0, > has been removed by policy CMP0153. Use the execute_process() command > instead." > > Though it's possible cmake is using the word "removed" in a way which > doesn't actually mean "removed". Yes, something like is triggered, but it's just a warning. doas -u _pbuild ninja uninstall [1/1] cd /usr/ports/pobj/kmbox-23.08.2/build-amd64 && /usr/local/bin/cmake -P /usr/ports/pobj/kmbox-23.08.2/build-amd64/ecm_uninstall.cmake FAILED: CMakeFiles/uninstall /usr/ports/pobj/kmbox-23.08.2/build-amd64/CMakeFiles/uninstall cd /usr/ports/pobj/kmbox-23.08.2/build-amd64 && /usr/local/bin/cmake -P /usr/ports/pobj/kmbox-23.08.2/build-amd64/ecm_uninstall.cmake -- Uninstalling /usr/local/lib/libKPim5Mbox.so.0.0 CMake Warning (dev) at ecm_uninstall.cmake:10 (exec_program): Policy CMP0153 is not set: The exec_program command should not be called. Run "cmake --help-policy CMP0153" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Use execute_process() instead. This warning is for project developers. Use -Wno-dev to suppress it. CMake Error at ecm_uninstall.cmake:16 (message): Problem when removing /usr/local/lib/libKPim5Mbox.so.0.0 > > > +https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9085 > ... > > +- this->OpenBSD = this->Makefile->GetState()->GetGlobalPropertyAsBool( > > ++ this->IsOpenBSD = this->Makefile->GetState()->GetGlobalPropertyAsBool( > > This has been there for a *long* time. Any idea why they started pulling > in param.h such that it became a problem? > Not on the quick, it's not obvious.
