On Sun, Dec 10, 2023 at 08:20:00PM +0900, SASANO Takayoshi wrote:
> Hi, thanks for your review.
> 
> Here is the second version of ports.
> 
> - DESCR rewrited
> - Makefile fixed
> - new patches supported FIX_CRLF_FILES
> 
> Regards,
> 
> -- 
> SASANO Takayoshi (JG1UAA) <u...@mx5.nisiq.net>
> 

I think you should consider adding yourself as maintainer. Any
objections?

You also need to add fluidsynth to WANTLIB:

Missing: fluidsynth.2 from fluidsynth-1.1.9p1 (/usr/local/bin/dosbox-x)
WANTLIB += fluidsynth

I recommend routinely running the following checks on your port which
will catch a lot of these issues:

1. make update-plist
2. make port-lib-depends-check
3. portcheck (/usr/ports/infrastructure/bin/portcheck)

I like the DESCR now much better and the warning about FIX_CRLF_FILES is
gone.

I can launch a dosbox-x terminal with this. With fluidsynth added to
WANTLIB, this is ok thfr@.

Reply via email to