On Mon, Dec 11, 2023 at 10:52:58PM +0300, Alexander Pavlov wrote: > Hello! > Thanks @Kirill for approved the pull request. > > This is my other ever port for OpenBSD. It's the open source Serious Sam > Classic engine with vulkan support. The port has two renders OpenGL and > Vulkan. Render switches to the game menu. > > Tested using the OpenGL renderer, since I do not have the opportunity to > test the Vulkan renderer on OpenBSD. On the computer where OpenBSD is > installed, the Radeon HD3000 does not support Vulkan. > > I wish to get this added to the official ports tree, so please leave > any feedback or suggestions on what can be improved. Thank you! > > Source on Github: > https://github.com/tx00100xt/SeriousSamClassic-VK
Thanks for submitting this: > @conflict serioussam-* Is this needed? We don't have any other serioussam ports as far as I know. DESCR should be formatted, typically with fmt -w 80... README also should be formatted similarly. This means that the line with "directories:" should be pulled up, even if you're going with fmt -w 72 only. Looks like SamTFE/Sources/CMakeLists.txt and SamTSE/Sources/CMakeLists.txt add their own -O2 and -pipe which is better left to our ports build system. I'm getting a segfault in vulkan when trying to launch: $ serioussam STUBBED: load window icon in /usr/ports/pobj/serioussam-vk-1.10.6c/SeriousSamClassic-VK-1.10.6c/SamTFE/Sources/SeriousSam/MainWindow.cpp, line 176. STUBBED: Need SDL invisible window or something in /usr/ports/pobj/serioussam-vk-1.10.6c/SeriousSamClassic-VK-1.10.6c/SamTFE/Sources/SeriousSam/MainWindow.cpp, line 357. STUBBED: !!! FIXME: get the code back in from Ryan's original port. in /usr/ports/pobj/serioussam-vk-1.10.6c/SeriousSamClassic-VK-1.10.6c/SamTFE/Sources/Engine/Base/Stream.cpp, line 995. STUBBED: Report actual SDL device name? in /usr/ports/pobj/serioussam-vk-1.10.6c/SeriousSamClassic-VK-1.10.6c/SamTFE/Sources/Engine/Sound/SoundLibrary.cpp, line 270. Segmentation fault (core dumped) With this here as part of the backtrace: #0 0x000004de18ccda2f in ?? () from /usr/X11R6/lib/libvulkan_intel.so No symbol table info available. #1 0x000004de18e3dc49 in ?? () from /usr/X11R6/lib/libvulkan_intel.so No symbol table info available. #2 0x000004de3b846d14 in SvkMain::InitTexture32Bit(unsigned int&, VkFormat, void*, VkExtent2D*, unsigned int, bool) () from /usr/local/lib/libEngine.so.0.0 That's on an Intel Tigerlake integrated GPU.
