On 2023/11/23 21:19, Stefan Hagen wrote:
> Hi,
> 
> Hukadan wrote (2023-11-20 21:07 CET):
> > > Here is a new port proposal. Pydio cells is a file sharing
> > > solution written in go. It is a good alternative to Nextcloud
> > > for those who only need the file sharing feature.
> > > 
> > > This is only my second port so feedback are more than welcome.
> > > I have been running it for few weeks now without any issue.
> >
> > Sorry, I forgot to put the homepage...
> > Here it is:
> > https://pydio.com/en/pydio-cells/overview
> 
> The port indeed needs some fixing:
> 
> - The distinfo file is wrong
> 
> It looks like you bumped the version number without regenerating it.
> 
> - COMMENT and DESCR could be a bit more specific / detailed
> - The user.list entry has user/group ID 894 but in PLIST it is 900
> - PKGNAME is set automatically for go ports, no need to set it
> - PREFIX = ${VARBASE}. This is the wrong approach.
> 
> You can use VARBASE in the install target, don't change PREFIX.
> 
> Note that you need SUBST_VARS to make VARBASE available in the PLIST.

Don't use VARBASE for that. That is for the base OS, packages don't
belong there.

There are some existing ports which use VARBASE: they are wrong.

For packages you want LOCALSTATEDIR or honestly I don't see a problem
with just using /var. It's not like there is any way to change where
it points without recompiling every package and most likely fixing a
load of stuff on the way.

dir     base                    packages
/etc    BASESYSCONFDIR          SYSCONFDIR
/var    VARBASE                 LOCALSTATEDIR

Reply via email to