On 2023/11/23 11:21:10 +0000, Klemens Nanni <k...@openbsd.org> wrote:
> On Thu, Nov 23, 2023 at 08:32:43AM +0100, Stefan Hagen wrote:
> > Minitube has just removed the note about the youtube key. That it is
> > still supported is nowhere to be found, except in the issues and the
> > code of course.
> >
> > https://github.com/flaviotordini/minitube/commit/7b4ef7f8aa76f316e1396a0b7b7dcde4874e0ede#diff-04c6e90faac2675aa89e2176d2eec7d8
> >
> > The YT app instructions are... mostly correct. This is a moving target.
> > Some parts have moved. There is no dropdown anymore where a dropdown is
> > mentioned. The settigs for the v3 API are nowhere to be found, I guess
> > it's default or removed.
>
> Right, yt3.cpp is still built so GOOGLE_API_KEY handling is still built-in.
>
> > But I could create an app with it and got a secret key. But... running
> > minitube with the GOOGLE_API_KEY exported still contacted Invidious
> > according to ktrace.
> >
> > Given the fact the minitube works fine without key, I'd be ok with
> > removing the README.
>
> Happy to do that unless someone knows better.
>
> > OK sdk@ for the subtle change, but also ok if you want to go further.
it's missing a `make update-plist' to remove the README entry from it,
otherwise I think it'll fail at packaging. ok op@ too fwiw
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/minitube/Makefile,v
> diff -u -p -r1.74 Makefile
> --- Makefile 27 Sep 2023 19:13:03 -0000 1.74
> +++ Makefile 23 Nov 2023 03:36:09 -0000
> @@ -2,7 +2,7 @@ COMMENT = standalone YouTube.com video b
>
> V = 3.9.3
> DISTNAME = minitube-$V
> -REVISION = 1
> +REVISION = 2
> EXTRACT_SUFX = .tar.bz2
>
> CATEGORIES = www multimedia
> Index: pkg/README
> ===================================================================
> RCS file: pkg/README
> diff -N pkg/README
> --- pkg/README 11 Mar 2022 20:10:06 -0000 1.7
> +++ /dev/null 1 Jan 1970 00:00:00 -0000
> @@ -1,42 +0,0 @@
> -+-----------------------------------------------------------------------
> -| Running ${PKGSTEM} on OpenBSD
> -+-----------------------------------------------------------------------
> -
> -Google API key
> -==============
> -An API key is required in order to access the YouTube Data web services.
> -
> -Go to https://console.developers.google.com/
> -
> -Log in using your Google account
> -
> -Click on "Create Project"
> -
> -Enter a Project name (e.g.: "Minitube")
> -
> -On the left side bar, expand the "APIs & auth" drop-down menu and
> -click on "Credentials"
> -
> -Click on "Create new Key" and then on "Browser key"
> -
> -Click on "Create"
> -
> -You should get an output like the one below:
> -
> -Key for browser applications
> - API key AIzaSyD7zlL9sAC6-IcwU7Bpds8lZNzmqQTmALQ
> - Referers Any referer allowed
> - Activation date Apr 28, 2015, 2:02:00 AM
> - Activated by john...@gmail.com (you)
> -
> -Be sure that "YouTube Data API v3" is enabled under "APIs & auth" ->
> -"APIs" -> "Enabled APIs"
> -
> -If not, go to "APIs & auth" -> "APIs" -> "API Library", click on "YouTube
> -Data API" and then on "Enable API" to enable it.
> -
> -Add the environment variable containing your newly generated key
> -to your ~/.profile or ~/.xsession:
> -
> -GOOGLE_API_KEY="AIzaSyD7zlL9sAC6-IcwU7Bpds8lZNzmqQTmALQ"
> -export GOOGLE_API_KEY
