On 2023/11/08 11:10, Antoine Jacoutot wrote: > On the other hand a hackathon is starting. So it might be a good time for it?
Unless other ports start depending to them, adding them to the build gives no information at all, since they won't even get installed. Might be a good time for a test build with them linked and manually installed (so DPB doesn't junk them). We might even get lucky and see actual build failures, though check-lib-depends would be more useful. > — > Antoine > > > On Nov 8, 2023, at 11:08, Stuart Henderson <s...@spacehopper.org> wrote: > > > > On 2023/11/08 09:55, Matthieu Herrb wrote: > >> Hi, > >> > >> when importing the ports needed for wayland, not yet linked to the > >> build, I did not add them to the Makefiles. This fixes that. > >> rsadowski@ took care of the wayland/ directory. > > > > I'd prefer to have "wayland" included in the commented-out lines so it's > > obvious why it's done (and so we can find them more easily), then it's > > ok sthen@. > > > >> Or is it time to try to link those to the build and see what happens > >> in a full bulk? > > > > Just running a bulk with them hooked isn't enough. To get good > > information from a bulk, we really want to make sure they're installed > > throughout the build and look for things linking to them - run > > check-lib-depends on the produced packages; there will be a lot of noise > > because nobody has done a full sync of LIB_DEPENDS/WANTLIB for ages, > > and because check-lib-depends doesn't handle subdirectories properly, > > so grepping for the specific libraries we're intereated is the way to > > go. Without something like this there's a long drawn-out process where > > things might break but usually won't on any given build, and hidden > > dependencies won't show up unless we get lucky with DPB junking. > > > >> Index: graphics/Makefile > >> =================================================================== > >> RCS file: /local/cvs/ports/graphics/Makefile,v > >> diff -u -p -u -r1.604 Makefile > >> --- graphics/Makefile 31 Oct 2023 13:16:10 -0000 1.604 > >> +++ graphics/Makefile 8 Nov 2023 09:50:01 -0000 > >> @@ -147,6 +147,7 @@ > >> SUBDIR += libimagequant > >> SUBDIR += libiptcdata > >> SUBDIR += libjxl > >> + #SUBDIR += libliftoff > >> SUBDIR += liblqr > >> SUBDIR += libmng > >> SUBDIR += libmpeg2 > >> Index: sysutils/Makefile > >> =================================================================== > >> RCS file: /local/cvs/ports/sysutils/Makefile,v > >> diff -u -p -u -r1.702 Makefile > >> --- sysutils/Makefile 27 Oct 2023 18:48:42 -0000 1.702 > >> +++ sysutils/Makefile 8 Nov 2023 09:50:09 -0000 > >> @@ -154,7 +154,9 @@ > >> SUBDIR += kubectl > >> SUBDIR += lf > >> SUBDIR += libburn > >> + #SUBDIR += libdisplay-info > >> SUBDIR += libesedb > >> + #SUBDIR += libevdev-openbsd > >> SUBDIR += libevt > >> SUBDIR += libevtx > >> SUBDIR += libfsapfs > >> @@ -381,6 +383,7 @@ > >> SUBDIR += salt-testing > >> SUBDIR += sblim-sfcc > >> SUBDIR += screenfetch > >> + #SUBDIR += seatd > >> SUBDIR += sec > >> SUBDIR += serf > >> SUBDIR += setquota > >> > >> -- > >> Matthieu Herrb > >> > > >
