Hi Stuart, On Friday, October 27, 2023 11:35 CEST, Stuart Henderson <s...@spacehopper.org> wrote:
> On 2023/10/26 17:04, Sebastian Reitenbach wrote:
> > Hi,
> >
> > an update of www/puppetboard needs a few new dependencies, this is one of
> > them.
> > Makes the puppetboard update happy for me.
> >
> > comments, or OK to import?
> >
> > Sebastian
>
> my comments for py-cachelib re MODPY_SETUPTOOLS->MODPY_PYBUILD and
> MODPY_PYTEST apply; also
>
> : DISTNAME = APScheduler-${MODPY_EGG_VERSION}
> : PKGNAME = py-${DISTNAME}
>
> with a port directory "py-apscheduler" I'd prefer matching case for the
> package, i.e. "py-${DISTNAME:L}" to make it all lower case.
>
> : CATEGORIES = devel
>
> sysutils feels a better fit for this one?
>
> : RUN_DEPENDS += devel/py-six${MODPY_FLAVOR} \
> : devel/py-tz${MODPY_FLAVOR} \
> : devel/py-tzlocal${MODPY_FLAVOR} \
> : www/py-tornado${MODPY_FLAVOR}
>
> looking at setup.py, py-tornado is optional; I think I'd probably move
> it to TEST_DEPENDS, where I would also list the other of the optional
> deps which are in ports that can be used by tests:
>
> TEST_DEPENDS = databases/py-mongo${MODPY_FLAVOR} \
> databases/py-sqlalchemy${MODPY_FLAVOR} \
> devel/py-twisted${MODPY_FLAVOR} \
> www/py-tornado${MODPY_FLAVOR}
>
> : # 381 passed, 146 skipped, 5 warnings, 2 errors (some optional deps)
>
> not sure it's worth including this line without information about
> the specific errors (no idea if the errors I see are the ones you see).
> could add this:
>
> # errors in test_executors_py35.py: io_loop and gen_test are in
> # pytest-tornado which is not in ports
>
> (the skipped ones from test_jobstores.py are self-explanatory and don't
> report as errors so I wouldn't bother mentioning those)
>
Incorporated all above feedback, thanks for that, as well as moved it
under sysutils.
Esp. regarding TEST_DEPENDS and the comment, got it to pass all tests,
added all available dependencies, and with running redis and mongod.
does that look OK?
Sebastian
py-apscheduler.tar.gz
Description: application/gzip
