Hi, On Friday, October 27, 2023 11:14 CEST, Stuart Henderson <s...@spacehopper.org> wrote:
> On 2023/10/26 17:05, Sebastian Reitenbach wrote:
> > Hi,
> >
> > an update of www/puppetboard needs a few new dependencies, this is one of
> > them.
> > Makes the puppetboard update happy for me.
> >
> > comments, or OK to import?
> >
> > Sebastian
>
> : MODPY_SETUPTOOLS = Yes
> : MODPY_PYTEST = Yes
>
> Please don't use MODPY_SETUPTOOLS for new ports, use MODPY_PYBUILD
> set to the correct value for the port.
>
> In this case, there's no pyproject.toml and it doesn't use
> setuptools_scm, so MODPY_PYBUILD=setuptools is the right one.
> If there's a pyproject.toml then look for "build-backend"; if not
> present then setuptools is the default. If present then hopefully
> it will imply one of the existing options (flit_core, flit, hatchling,
> hatch-vcs, poetry-core, setuptools, setuptools_scm) - if not then
> the python module may need to be extended.
>
> MODPY_PYBUILD implicitly sets MODPY_PYTEST anyway so that's no longer
> needed either.
>
> : # 11 failed, 86 passed, 35 skipped (dynamodb tests fail)
>
> Depends whether py3-boto3 is installed; if so, the tests seem to hang
> (though they might just be timing out very slowly). Anyway,
>
> Since there's nothing setup to handle dynamodb in the port, it seems
> reasonable to simply skip that test. (If py3-boto3 is installed, the
> failed tests take a long time to report failure; in that case it looks
> like it's hanging unless you're patient).
>
> If you apply the below Makefile diff and regenerate PLIST then it's
> OK sthen@.
>
>
> --- Makefile.orig Fri Oct 27 10:03:18 2023
> +++ Makefile Fri Oct 27 10:09:25 2023
> @@ -11,13 +11,11 @@ PERMIT_PACKAGE = Yes
>
> MODULES = lang/python
> MODPY_PI = Yes
> -MODPY_SETUPTOOLS = Yes
> -MODPY_PYTEST = Yes
> +MODPY_PYBUILD = setuptools
>
> FLAVORS = python3
> FLAVOR = python3
>
> -# 11 failed, 86 passed, 35 skipped (dynamodb tests fail)
> -TEST_DEPENDS += devel/py-test-xprocess${MODPY_FLAVOR}
> +MODPY_PYTEST_ARGS = --ignore tests/test_dynamodb_cache.py
>
> .include <bsd.port.mk>
thanks a bunch for that insightful feedback. As usual, very helpful.
Patch applied, had to keep the TEST_DEPENDS line in, otherwise, tests wouldn't
run at all. Assume that's fine.
cheers,
Sebastian
py-cachelib.tar.gz
Description: application/gzip
