Stuart Henderson wrote (2023-10-21 11:41 CEST):
> I'd probably go with this, there doesn't seem any need to install two
> copies of the same sample files.

Sure, having the files can be a hint that these can be edited. But
it's okay to leave them out.

I'll commit your diff.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/detox/Makefile,v
> retrieving revision 1.6
> diff -u -p -r1.6 Makefile
> --- Makefile  27 Sep 2023 17:16:24 -0000      1.6
> +++ Makefile  21 Oct 2023 09:40:15 -0000
> @@ -1,19 +1,18 @@
>  COMMENT =            utility designed to clean up filenames
>  
> -DISTNAME =           detox-1.2.0
> +V =                  1.4.5
> +DISTNAME =           detox-${V}
>  
>  CATEGORIES =         sysutils
>  
> -HOMEPAGE =           http://detox.sourceforge.net/
> +HOMEPAGE =           https://github.com/dharple/detox
>  
>  #BSD
>  PERMIT_PACKAGE =     Yes
>  
>  WANTLIB +=           c
>  
> -SITES =                      ${SITE_SOURCEFORGE:=detox/}
> -
> -EXTRACT_SUFX =               .tar.bz2
> +SITES =                      ${HOMEPAGE}/releases/download/v${V}/
>  
>  USE_GMAKE =          Yes
>  
> @@ -21,16 +20,6 @@ CONFIGURE_STYLE =  gnu
>  
>  NO_TEST =            Yes
>  
> -do-install:
> -     ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/detox
> -     ${INSTALL_DATA_DIR} ${PREFIX}/share/detox
> -     ${INSTALL_PROGRAM} ${WRKBUILD}/detox ${PREFIX}/bin
> -     ${INSTALL_PROGRAM} ${WRKBUILD}/inline-detox ${PREFIX}/bin
> -     ${INSTALL_MAN} ${WRKBUILD}/detox.1 ${PREFIX}/man/man1
> -     ${INSTALL_MAN} ${WRKBUILD}/detoxrc.5 ${PREFIX}/man/man5
> -     ${INSTALL_MAN} ${WRKBUILD}/detox.tbl.5 ${PREFIX}/man/man5
> -     ${INSTALL_DATA} ${WRKBUILD}/detoxrc ${PREFIX}/share/examples/detox
> -     ${INSTALL_DATA} ${WRKBUILD}/iso8859_1.tbl ${PREFIX}/share/detox
> -     ${INSTALL_DATA} ${WRKBUILD}/unicode.tbl ${PREFIX}/share/detox
> +FAKE_FLAGS =         sysconfdir=${PREFIX}/share/examples/detox
>  
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/sysutils/detox/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo  18 Jan 2015 03:15:09 -0000      1.2
> +++ distinfo  21 Oct 2023 09:40:15 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (detox-1.2.0.tar.bz2) = q/rZDufT4PxTzjudoyU/moAM3ZLj+MwSoZOUp7Hc2/g=
> -SIZE (detox-1.2.0.tar.bz2) = 86118
> +SHA256 (detox-1.4.5.tar.gz) = uKDtgw8wVPvgl3HSuO2K42Z1KWeMGnPrjlEmk+jHTTw=
> +SIZE (detox-1.4.5.tar.gz) = 147196
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/sysutils/detox/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -r1.2 PLIST
> --- pkg/PLIST 11 Mar 2022 19:57:20 -0000      1.2
> +++ pkg/PLIST 21 Oct 2023 09:40:15 -0000
> @@ -1,11 +1,19 @@
>  @bin bin/detox
>  @bin bin/inline-detox
>  @man man/man1/detox.1
> +@man man/man1/inline-detox.1
>  @man man/man5/detox.tbl.5
>  @man man/man5/detoxrc.5
>  share/detox/
>  share/detox/iso8859_1.tbl
> +@comment share/detox/iso8859_1.tbl.sample
> +share/detox/safe.tbl
> +@comment share/detox/safe.tbl.sample
>  share/detox/unicode.tbl
> +@comment share/detox/unicode.tbl.sample
> +share/doc/detox/
> +share/doc/detox/README.md
>  share/examples/detox/
>  share/examples/detox/detoxrc
>  @sample ${SYSCONFDIR}/detoxrc
> +@comment share/examples/detox/detoxrc.sample
> 

Reply via email to