Thanks for picking this up and finishing it!
I'm OK with your being opencascade maintainer.
I built the opencascade and prusaslicer 2.5.2p1 and that seems to work
as before. Didn't test kicad but it's a trivial change and you've tested
it. So those three are OK ian@.
You probably need a 'quirks' entry and/or a conflict marker for anyone
who might have the older oce installed. Probably a conflict entry, and
then remove the old one in a few days?
On 10/19/23 03:42, Johannes Thyssen Tishman wrote:
Please find attached a port for opencascade (occt) intended for the
replacement of the outdated and unmaintained[1] cad/oce in
cad/{kicad,prusaslicer} (and for a future FreeCAD port). For context,
oce is a community driven fork of the Open CASCADE library (occt)
which is also why the ports share a lot in common (many bits were
taken from cad/oce). The replacement is very straightforward and
almost drop-in (see kicad.diff and prusaslicer.diff). With this
change I also suggest the removal of cad/oce as it conflicts with
cad/opencascade and it would no longer make sense to keep it.
Tested both consumers which seem to work great. However more testing
would be appreciated.
I've cc's Renato (maintainer of prusaslicer) and ian@ as he worked
on the wip port as well.
ian@: You were listed as the MAINTAINER of this port in the wip
version[2], but since I'm making this submission without your
consent, I've taken it over. Please let me know if you want it back
or if you'd like to co-maintain it together.
