On Wed, 20 Sep 2023, Stuart Henderson wrote:
> need runtime checks of dependents, these problems don't show up in build
>
The good news is that I didn't notice anything new that broke at runtime.
The bad news is tons of stuff in the Python tree is already broken at
runtime. This has nothing to do with click though, that's a pretty
generic comment.
Just looking at the click dependencies alone... some examples of either
outright brokeness or missing test depends:
devel/py-xdis -- broken when we went past python 3.10.9 (and so is
devel/py-uncompyle6 which has the same issue of hardcoding very specific
python versions). These can be fixed by someone who cares enough to update
to latest versions on github.
www/tootstream -- broken at runtime (ImportError: cannot import name
'attr' from 'colored'). Not sure if an update to py-colored or tootstream
itself broke runtime.
security/boofuzz -- missing TDEP on pytest_bdd
security/yubico/yubikey-manager -- missing TDEP on makefun
math/py-snuggs still has the same 3 failing tests with no activity
upstream in the last 4 years and users of geo/py-rasterio asking the
rasterio probject to find some way to migrate away from snuggs or fork it.
No change from a click update.
Of the rest of the things I checked, I didn't see new breakage due to
click. Some of them even had test suites that ran, most things don't have
test suites or generate lots of errors when trying to run the tests.
So from what I can tell, I think the update to click itself is ok.
Most importantly to me, the www/py-flask test suite continues to pass:
===> Regression tests for py3-flask-2.1.3
============================= test session starts ==============================
platform openbsd7 -- Python 3.10.13, pytest-7.1.3, pluggy-1.2.0
rootdir: /usr/ports/pobj/py-flask-2.1.3-python3/Flask-2.1.3, configfile:
setup.cfg, testpaths: tests
plugins: hypothesis-6.47.1, cov-4.0.0, localserver-0.7.1,
requests-mock-1.5.2
collected 472 items / 1 skipped
tests/test_appctx.py .............. [ 2%]
tests/test_basic.py .................................................... [ 13%]
........................................................................ [ 29%]
...... [ 30%]
tests/test_blueprints.py ............................................... [ 40%]
.......... [ 42%]
tests/test_cli.py ............................................ss.s...... [ 54%]
[ 54%]
tests/test_config.py ................... [ 58%]
tests/test_converters.py .. [ 58%]
tests/test_helpers.py .............................. [ 64%]
tests/test_instance_config.py ........... [ 67%]
tests/test_json.py ................................. [ 74%]
tests/test_json_tag.py .............. [ 77%]
tests/test_logging.py ...... [ 78%]
tests/test_regression.py . [ 78%]
tests/test_reqctx.py .......ss..... [ 81%]
tests/test_session_interface.py . [ 81%]
tests/test_signals.py ....... [ 83%]
tests/test_subclassing.py . [ 83%]
tests/test_templating.py ............................... [ 90%]
tests/test_testing.py .......................... [ 95%]
tests/test_user_error_handler.py ......... [ 97%]
tests/test_views.py ............ [100%]
======================== 467 passed, 6 skipped in 3.58s ========================
