Hi Stuart,

> What is more of a problem for the all-in-one approach is that building
> some parts requires finding python modules done as part of the shiboken
> build, and the way that the build is being run in this port, that
> doesn't work, it's not passing in a PYTHONPATH that allows it to find
> them.
> 
> It seems that the build is intended to be run by their python setup.py
> scripts which then call cmake - whereas you're calling cmake directly,
> which might be reponsible for this.

You're probably right. I used the FreeBSD port as a reference and
they seem to be calling cmake directly (I think). How can I use the
setup.py script as intended without turning the port into a python
module? MODPY_PYBUILD? Or do I have to override the do-build target?

> Anyway separate ports probably seems like less of a headache to me
> for this.
> 
> I would probably group them under one dir, x11/pyside6 (not devel/),
> with subdirs for the different things and share common parts via
> x11/pyside6/Makefile.inc
> 
> ports/x11/pyside6/pyside6
> ports/x11/pyside6/tools
> ports/x11/pyside6/shiboken

This indeed seems like a less cumbersome yet organized solution.
Would you prefer this solution using cmake directly even if the
all-in-one approach works when using the setup.py script?

> check-lib-depends doesn't properly handle libraries in subdirs.

Ah I see, so I assume I can safely ignore this? Should I perhaps
make a comment somewhere about it? Also, for the clang runtime
dependency, is the lang/clang module enough or do I need to add
devel/llvm/13 to LIB_DEPENDS?

As usual, thanks for the very informative feedback Stuart and for
taking the time to look into the ports.

Kind regards,
Johannes

Reply via email to