On 2023/09/16 11:08:05 +0200, Rafael Sadowski <raf...@sizeofvoid.org> wrote:
> Unified error messages for all missing RUN_DEPENDS.
makes sense to me
> I prefer "RUN_DEPENDS${subpkg}+=" as error message as under dbus,-suid
> (copy paste friendly). If that's not what the majority wants, we should
> adjust the dbus,-suid
> msg.
>
> OK?
ok op@
> Index: portcheck
> ===================================================================
> RCS file: /cvs/ports/infrastructure/bin/portcheck,v
> retrieving revision 1.145
> diff -u -p -r1.145 portcheck
> --- portcheck 5 Sep 2023 13:52:44 -0000 1.145
> +++ portcheck 16 Sep 2023 08:05:12 -0000
> @@ -1191,18 +1191,21 @@ check_plist() {
> # gtk-update-icon-cache
> $guic_dep_needed && ! $guic_dep &&
> [[ $fullpkgname != gtk-update-icon-cache-* ]] &&
> - err "${portref}missing RDEP on x11/gtk+4,-guic"
> + err "${portref}missing" \
> + "RUN_DEPENDS${subpkg}+=x11/gtk+4,-guic"
> local cnt
>
> # desktop-file-utils (simplier than previous, isn't it?)
> $mime_dep_needed && ! $mime_dep &&
> [[ $fullpkgname != desktop-file-utils-* ]] &&
> - err "${portref}missing RDEP on devel/desktop-file-utils"
> + err "${portref}missing" \
> + "RUN_DEPENDS${subpkg}+=devel/desktop-file-utils"
>
> # update-mime-database (same as previous)
> $mimepkg_dep_needed && ! $mimepkg_dep &&
> [[ $fullpkgname != shared-mime-info-* ]] &&
> - err "${portref}missing RDEP on misc/shared-mime-info"
> + err "${portref}missing" \
> + "RUN_DEPENDS${subpkg}+=misc/shared-mime-info"
>
> # glib-compile-schemas (almost same as previous)
> #
