I don’t think icewm is in scope for this change :-) 

—
Antoine

> On 15 Sep 2023, at 19:48, Josh Grosse <j...@jggimi.net> wrote:
> 
> On Fri, Sep 15, 2023 at 07:31:00PM +0200, Antoine Jacoutot wrote:
>>> On Fri, Sep 15, 2023 at 12:22:59PM -0400, Josh Grosse wrote:
>>> During bulk build, naddy@ took note of a missing libdep
>>> in net/transmission's Makefile.  The build failed to
>>> find libdeflate due to the bulk build's junk removal.
>>> 
>>> This patch adds the explicit libdep.  Builds and runs on amd64.
>> 
>> Have you run port-lib-depends-check?
>> Because if you add an LDEP you need the corresponding WANTLIB (deflate in 
>> this
>> case).
> 
> Revised diff attached.  Thank you for catching my error! 
> 
>> 
>>> diff --git a/net/transmission/Makefile b/net/transmission/Makefile
>>> index 335908e903f..e2cf1338446 100644
>>> --- a/net/transmission/Makefile
>>> +++ b/net/transmission/Makefile
>>> @@ -10,9 +10,9 @@ PKGNAME-qt=    transmission-qt-${VER}
>>> CATEGORIES=    net
>>> HOMEPAGE=    https://transmissionbt.com/
>>> MAINTAINER=    Josh Grosse <j...@jggimi.net>
>>> -REVISION-gtk=    0
>>> -REVISION-main=    0
>>> -REVISION-qt=    0
>>> +REVISION-gtk=    1
>>> +REVISION-main=    1
>>> +REVISION-qt=    1
>>> 
>>> # GPLv2+
>>> PERMIT_PACKAGE=    Yes
>>> @@ -46,7 +46,8 @@ WANTLIB-qt +=    Qt6Widgets
>>> MODULES +=        devel/cmake \
>>>            textproc/intltool
>>> 
>>> -LIB_DEPENDS-common +=    net/curl \
>>> +LIB_DEPENDS-common +=    archivers/libdeflate \
>>> +            net/curl \
>>>            net/libpsl \
>>>            net/miniupnp/libnatpmp \
>>>            net/miniupnp/miniupnpc>=1.9
>> 
>> 
>> -- 
>> Antoine
>> 
> <net.transmission.v2.diff>

Reply via email to