On 2023/09/14 21:38, Volker Schlecht wrote:
> On 9/14/23 19:58, Peter Hessler wrote:
> > On 2023 Sep 14 (Thu) at 11:37:57 -0600 (-0600), phess...@openbsd.org wrote:
> > :critical path missing pkgs:  
> > http://build-failures.rhaalovely.net/aarch64/2023-09-12/summary.log
> > :
> > :http://build-failures.rhaalovely.net/aarch64/2023-09-12/cad/prusaslicer.log
> > 
> > new port, new failure:
> > 
> [...]
> >   
> > /usr/obj/ports/prusaslicer-2.5.2/PrusaSlicer-version_2.5.2/src/libslic3r/pchheader.hpp:107:10:
> >  fatal error: 'Eigen/Dense' file not found
> >   #include <Eigen/Dense>
> >            ^~~~~~~~~~~~~
> >   1 error generated.
> > 
> > Guessing it is a missing dep?
> 
> Seems that configure picks up eigen in your build environment:
> 
> [...]
> -- Found ZLIB: /usr/lib/libz.so.7.0 (found version "1.3")
> -- Found Eigen3: /usr/local/include/eigen3 (Required is at least version
> "3.3")
> -- Could NOT find EXPAT (missing: EXPAT_DIR)
> -- Falling back to MODULE search for EXPAT...
> [...]
> 
> On amd64 I get a clean build both with and without eigen3 - is it
> possible that eigen3 was around during confgure and then removed mid-build?

It's very likely. This is totally normal in a bulk build.
Ports must either list dependencies for everything which they might
pick up, or disable them. It's usually necessary to at least look
through configure output to pick these up (and sometimes things are
picked up which aren't printed by configure).

There are some other issues,

- some libraries used directly by the port are only listed in WANTLIB but
should really be in LIB_DEPENDS so that someone updating those libraries
knows that it might affect prusaslicer: graphics/png, net/curl

- LIB_DEPENDS on devel/gmp is missing (gmp,-cxx is still needed as a
BUILD_DEPENDS because it picks up the headers for something, but doesn't
seem to actually link the library so no WANTLIB/LIB_DEPENDS)

- cmake picks up archivers/blosc if present, though it's not clear what
it does with it... may also need a BUILD_DEPENDS
"-- Found Blosc: /usr/local/lib/libblosc.so.2.0 (found version "1.21.4")"

(and, unless there's a particular reason, e.g. to keep in sync with
ordering used upstream in a configure script or similar to assist in
checking for changed deps after a version update, we generally keep
LIB_DEPENDS in alphabetic order)

Reply via email to