On 09/07 01:45, Ingo Schwarze wrote: > Hi Jeremy, > > Jeremy Evans wrote on Wed, Sep 06, 2023 at 09:42:09PM +0000: > > > This updates ruby-module.5 to update it for recent changes and > > make other improvements: > > > > * Sort the list of variables. > > > > * Remove mention of variables removed from ruby.port.mk, and > > mention of jruby now that jruby support has been removed. > > > > I plan on committing this after the ruby.port.mk diff I sent, > > assuming there are no objections. > > Definitely no objection here. > > When having a very brief look at the page, i noticed a very unusual > style: first there is a giant list of variables with no explanation, > then references to them scattered around the rest of the text. > > Wouldn't something like > > .Bl -tag -width Ds > .It Ev MODRUBY_REV > The ruby version for a non-gem port. > The default is 3.2. > The other supported values are 3.0 and 3.1. > For a gem port, use a > .Ev FLAVOR > like > .Ql ruby31 > instead. > > be easier to read, more concise, look more familiar, be easier > to maintain and easier to search at the same time? Right now, > for example, ":t MODUBY_REV" does not work, and making mandoc(1) > cope with the present style looks very difficult to me.
Ingo, Thank you for the feedback. I agree with you. I will work on an updated patch that uses that style. Best regards, Jeremy
