On Thu, Sep 07, 2023 at 05:08:11PM +0200, Landry Breuil wrote:
> Le Thu, Sep 07, 2023 at 02:47:58PM +0000, Sergey A. Osokin a écrit :
> > 
> > There's no shared library for NJS at the moment, only static
> > library is available.
> 
> right. then ... i think BUILD_DEPENDS + RUN_DEPENDS is needed in the
> static case instead.
> 
> you might want to check WANTLIB too (make port-lib-depends-check), here
> it complains about missing xml2/z

Done.

A note here.  The /usr/ports/infrastructure/bin/portcheck reports about
xml2, that shared library is required for NJS functionality, it's
mentioned in NJS pkgconfig file, /usr/local/lib/pkgconfig/njs.pc, so I
added it to WANTLIB.  Hope that's OK.

-- 
Sergey A. Osokin

Index: Makefile.inc
===================================================================
RCS file: /cvs/ports/www/unit/Makefile.inc,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile.inc
--- Makefile.inc	5 Sep 2023 11:31:17 -0000	1.9
+++ Makefile.inc	7 Sep 2023 15:29:22 -0000
@@ -27,6 +27,7 @@ CONFIGURE_ARGS=	--prefix=${PREFIX} \
 		--pid=${LOCALSTATEDIR}/run/unit/unit.pid \
 		--runstatedir=${LOCALSTATEDIR}/run/unit \
 		--statedir=${LOCALSTATEDIR}/db/unit \
+		--njs \
 		--tmpdir=${LOCALSTATEDIR}/tmp/unit \
 		--openssl \
 		--user=_unit \
Index: unit/Makefile
===================================================================
RCS file: /cvs/ports/www/unit/unit/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- unit/Makefile	4 Sep 2023 17:02:21 -0000	1.6
+++ unit/Makefile	7 Sep 2023 15:29:22 -0000
@@ -1,8 +1,12 @@
 COMMENT=	dynamic web application server
 
-WANTLIB=	c crypto m pcre2-8 pthread ssl
+REVISION=	0
+
+WANTLIB=	c crypto m pcre2-8 pthread ssl xml2 z
 
 LIB_DEPENDS=	devel/pcre2
+BUILD_DEPENDS=	${RUN_DEPENDS}
+RUN_DEPENDS=	lang/njs
 
 MODULES=	lang/python
 MODPY_BUILDDEP=	No

Reply via email to