On 2023/09/06 23:50:23 +0000, Lucas <lu...@sexy.is> wrote: > Omar Polo <o...@omarpolo.com> wrote: > > > > [...] > > > > > > ok solene@ > > > > > > I tested it on 7.3-stable though, so ok to backport too :) > > > > I tested on 7.3-stable too! (with postgresql fwiw) > > > > ok op@, both for the update and the backport while you're at it :-) > > ftr, I'm not a commiter.
with all the due respect, that was meant for solene@. I wasn't clear, sorry ^^" > > > > Partly related: I wanted to switch it to Lua 5.4, but that requires > > > > adding lua54 FLAVOR to almost all the deps. Should I make that change > > > > in two parts, first enabling the FLAVORs and then switching Prosody to > > > > Lua 5.4, or should I fold all those changes into this patch? > > > > I'd first commit this as-is and backport to stable, then bump the deps > > to add the missing FLAVOR and switch prosody to lua 5.4. this way we > > avoid changing too many ports in -STABLE. -STABLE users will get > > prosody with lua5.4 with next release. > > This sound like a good approach. > > > fwiw i'm perfectly fine with the other way around too however, and > > happy to test diffs :-) > > Enjoy yourself! It's running fine in my server, but my setup doesn't > stress much of the deps. In particular, I don't use luadbi. I'll give this a spin on my setup where I use luadbi with postgresql. Note that i just committed a diff to update luasockets AND add a lua54 flavor to it, so if you get conflicts applying the diff is because of that. The rest should still apply cleanly. > This patch is on top of the previous. I didn't bump any REVISION but > Prosody's; my understanding is that it isn't needed as the new FLAVORS > imply new FULLPKGNAMEs. right. No existing packages are modified when adding a flavor, we only start to ship new ones. > Prosody's PLIST change is because the file is > called literally "util/bit53.lua", which I didn't spot in the past. It's ok op@ if someone wants to quickly take it, otherwise i'll commit later after some testing. (if committing, remember to hook the new flavors in the category' Makefile!) Thanks!
