On 2023/08/23 12:00, Marc Espie wrote: > I'm trying to figure out ways to make things shorter, as even the variable > names get insanely long. > > In particular, do we really need long names like > go_modules/golang.org/x/tools/@v/v0.0.0-20190907020128-2ca718005c18.mod ? > > It seems to me that > go/golang.org/x/tools/0.0.0-20190907020128-2ca718005c18.mod > > would be just as descriptive and not lose any information. > > Any part of the go tooling that actually wants the full name for a distfile ? > That little noise doesn't seem like much, but it quickly adds up. >
The "go_modules" part is just for distfiles and should be ok to change to "go". The "@v" part doesn't need to be there in distfiles (since I fixed what was IMHO quite a nasty mistake, see go.port.mk r1.36) but does need to be in the path for files copied into WRKDIR. Doesn't look like that would be a problem to change. Minor issue in that changing distfile paths means bulk builders will need to refetch ~18k files / 9GB, unless they copy the files to the new names (for official bulks we can just do this once on the nfs server).
