As it's not needed for normal use of vimb, it's probably better handled as
a note in DESCR or README than a hard dependency (same is done with ffmpeg
for video playback in Firefox).
--
Sent from a phone, apologies for poor formatting.
On 22 August 2023 22:50:48 Johannes Thyssen Tishman
<li...@thyssentishman.com> wrote:
Hi,
it seems that www/vimb requires multimedia/gstreamer1/plugins-libav
to play videos on certain websites like instances of Invidious or
Odysee (surprisingly YouTube doesn't need it). Therefore, I suggest
adding it as a RDEP to the port.
Also 'port-lib-depends-check' complained about some missing WANTLIBS.
Not sure if it has anything to do with the new RDEP or if they were
already missing. Anyways, diff below. Thanks!
Kind regards,
Johannes
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/vimb/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- Makefile 21 Jun 2023 10:59:13 -0000 1.25
+++ Makefile 22 Aug 2023 21:48:48 -0000
@@ -1,4 +1,5 @@
COMMENT = modal webkit-based browser inspired by vim
+REVISION = 0
GH_ACCOUNT = fanglingsu
GH_PROJECT = vimb
@@ -12,12 +13,14 @@ HOMEPAGE = https://fanglingsu.github.io/
PERMIT_PACKAGE = Yes
WANTLIB += atk-1.0 c cairo cairo-gobject gdk-3 gdk_pixbuf-2.0
+WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gtk-3 harfbuzz
WANTLIB += intl javascriptcoregtk-4.1 pango-1.0 pangocairo-1.0
WANTLIB += pthread soup-3.0 webkit2gtk-4.1
LIB_DEPENDS = www/webkitgtk4,webkitgtk41
-RUN_DEPENDS = devel/desktop-file-utils
+RUN_DEPENDS = devel/desktop-file-utils \
+ multimedia/gstreamer1/plugins-libav
USE_GMAKE = Yes
