On 2023/08/16 23:21:49 -0600, Ashlen <d...@anthes.is> wrote: > Description: > > """ > An opinionated code formatter for Lua 5.1, 5.2, 5.3, 5.4 and Luau, > built using full-moon. StyLua is inspired by the likes of prettier, > it parses your Lua codebase, and prints it back out from scratch, > enforcing a consistent code style. > > StyLua mainly follows the Roblox Lua Style Guide, with a few > deviations. > """ > > GitHub: https://github.com/JohnnyMorganz/StyLua > > > This was easy enough to port, nothing interesting to say really. > Tests run and pass. Tested runtime by using the formatter.nvim > plugin. > https://github.com/mhartington/formatter.nvim > > Suggestions/OKs?
Some tweaks for the makefile:
- the indentation of the value is off (you're not using tab multiples
of 8 columns?)
- homepage is already set by GH_*
- to lower-case the package name you can just do PKGNAME=${DISTNAME:L}
- typo on SEPARATE_BUILD (should be SEPARATED_BUILD)
- missing WANTLIBs
not sure why CONFIGURE_STYLE is needed but the build fails otherwise
and rust is out of my comfort zone. It also seem to build stuff
during fake, don't know if it's usual for rust ports.
It's sad that there's not documentation other than the README.md (that
isn't much legible with less(1)). stylua -h | less seems like a
manpage however, meh.
Quickly tested the port, it doesn't like one file I wrote but
otherwise seems to work fine.
I'm attaching a diff against your makefile and an updated tarball.
Provided the two points above are fine, ok op@ to import.
--- Makefile.orig Thu Aug 17 09:43:06 2023
+++ Makefile Thu Aug 17 10:18:31 2023
@@ -1,22 +1,19 @@
-COMMENT = opinionated Lua code formatter
-V = 0.18.1
-DISTNAME = stylua-${V}
+COMMENT = opinionated Lua code formatter
GH_ACCOUNT = JohnnyMorganz
GH_PROJECT = StyLua
-GH_TAGNAME = v${V}
+GH_TAGNAME = v0.18.1
+PKGNAME = ${DISTNAME:L}
CATEGORIES = devel
-HOMEPAGE = https://github.com/JohnnyMorganz/StyLua
-
# Mozilla Public License 2.0
PERMIT_PACKAGE = Yes
-MODULES = devel/cargo
-SEPARATE_BUILD = Yes
+WANTLIB = ${MODCARGO_WANTLIB}
+
+MODULES = devel/cargo
CONFIGURE_STYLE = cargo
.include "crates.inc"
-
.include <bsd.port.mk>
stylua.tar.gz
Description: GNU Zip compressed data
