On Tue, Aug 01, 2023 at 09:27:31AM +0200, Omar Polo wrote: > On 2023/07/31 22:17:05 +0000, Klemens Nanni <k...@openbsd.org> wrote: > > 'make patch' on a WXNEEDED=Yes port without wxallowed fails after > > patching and before creating the patch cookie, so subsequent setting > > of the option and rerunning the target will try to patch again. > > > > If the check is done right after extract, rerunning that target usually > > has higher chances of just working. > > > > Is there a reason I'm not aware of that this is done after patch? > > > > > > I just forgot to set wxallowed on /usr/ports/pobj when building > > ungoogled-chromium where 'make clean && mount ... && make patch' takes > > considerably longer than 'mount ... && make extract' to recover from > > forgetting to set wxallowed. > > I've been hit by this several times too (i.e. every time I look at > lang/sbcl) so fwiw I welcome this change!
As I recall it, I do not believe there was a specific reason for me to put it in _post-patch-finalize. The main impetus was lang/python failing to configure with a confusing error along the lines of "the C compiler is able to generate executables... no" which was reported many times.
