On Wed, Jun 14, 2023 at 12:57:52PM +0200, Martin REINDL wrote:
> Am 13.06.2023 um 20:39 schrieb Landry Breuil:
> > Le Tue, Jun 13, 2023 at 10:23:20AM +0200, Martin Reindl a écrit :
> > > On Thu, May 25, 2023 at 08:31:41AM +0200, Landry Breuil wrote:
> > > > Le Thu, May 25, 2023 at 01:45:54AM +0100, Stuart Henderson a écrit :
> > > > > On 2023/05/23 19:26, Martin Reindl wrote:
> > > > > > + # generated by 'telegraf config'
> > > > > > + ${INSTALL_DATA} ${FILESDIR}/telegraf.conf \
> > > > > > ${PREFIX}/share/examples/telegraf/
> > > > >
> > > > > would it make sense to use the newly built binary to generate this
> > > > > instead? I think the copy in FILESDIR is likely to get out of sync
> > > > > after
> > > > > updates.
> > > >
> > > > that was also my idea, and .. that would also exercise the binary that
> > > > was just built, which can be a nice canary for when go binaries are
> > > > broken by some other changes in src.
> > > >
> > > > so maybe this in do-install:
> > > > ${PREFIX}/bin/telegraf config >
> > > > ${PREFIX}/share/examples/telegraf/telegraf.conf
> > >
> > > As a followup, here is an update to the current 1.27.0 release. OK?
> >
> > wont be able to test until some weeks, but still ok for me. wait for
> > maintainer's feedback ofc ;)
> >
> > Landry
> >
>
> Sure, I will wait for Lucas' OK. The earlier diff without generated config
> file was fine with him back then.
>
> -m
still ok with me :)
