On Sun, Jun 11, 2023 at 08:47:50PM -0400, Brad Smith wrote:
> On Sun, Jun 11, 2023 at 10:41:18PM +0200, Antoine Jacoutot wrote:
> > Hi.
> > 
> > It seems that if textproc/nlohmann-json is around then dpb(1) junks it, the
> > build fails.
> > 
> > Full log attached.
> > 
> > -- 
> > Antoine
> 
> Musikcube has an internal copy of nlohmann-json. If it happens to be around 
> and
> due to the ordering of the header paths it will pick up the system copy. I 
> think
> it is easiest to just build with the system copy. Its just a header port.
> 
> Also g/c CONFIGURE_ARGS as it uses taglib anyway and add depends on lame.

Looks good portswise.

ok for me

> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/audio/musikcube/Makefile,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 Makefile
> --- Makefile  29 May 2023 17:54:37 -0000      1.7
> +++ Makefile  11 Jun 2023 23:58:29 -0000
> @@ -3,7 +3,7 @@ COMMENT =     terminal-based music player
>  GH_ACCOUNT = clangen
>  GH_PROJECT = musikcube
>  GH_TAGNAME = 3.0.0
> -
> +REVISION =   0
>  CATEGORIES = audio
>  
>  HOMEPAGE =   https://musikcube.com/
> @@ -19,10 +19,10 @@ COMPILER =        base-clang ports-gcc
>  
>  MODULES =    devel/cmake
>  
> -CONFIGURE_ARGS += -DENABLE_BUNDLED_TAGLIB=false
> -
> -BUILD_DEPENDS+=      devel/asio
> -LIB_DEPENDS =        audio/libopenmpt \
> +BUILD_DEPENDS+=      devel/asio \
> +             textproc/nlohmann-json
> +LIB_DEPENDS =        audio/lame \
> +             audio/libopenmpt \
>               audio/taglib \
>               devel/libev \
>               graphics/ffmpeg \
> 

-- 
Antoine

Reply via email to