On 2023/05/24 16:29, Nam Nguyen wrote: > Now that graphics/glslang is provides shared libraries, I would like to > adjust the flycast port. > > This inline diff: > - adds SPIRV and vulkan to WANTLIB. graphics/glslang now provides > SPIRV. vulkan is dlopen'ed so ignore the `make port-lib-depends-check' > warning. This is taken from games/fs2open. > - adds COMPILER line for C++ > - moves graphics/vulkan-loader from RUN_DEPENDS to LIB_DEPENDS. It > provides the dlopen'ed vulkan. RUN_DEPENDS was incorrect and other > consumers also list it as LIB_DEPENDS. > - bumps REVISION > > I tested using vulkan and opengl and confirmed that libvulkan.so.1.1 is > opened using `env LD_DEBUG= flycast' when using the vulkan backend. > > ok?
ok, though I'd prefer if you also moved DISTNAME/REVISION etc to a more usual location nearer the top of the file.