On 2023/05/24 10:30, Alexander Arkhipov wrote: > Hello, > > u2ps is a text-to-postscript utility like enscript, except that it > supports unicode, and doesn't try to pipe the output to lpr without > me asking. I followed the porters FAQ, and the tarball should be > MIME-attached to this message. I marked myself as MAINTAINER. > > I had some problems with the tests, and opened an issue[0] about > that on the program's github page. The compiler also gives me a > couple of warnings, but those are not critical. > > Any comments? > > [0] https://github.com/arsv/u2ps/issues/9
Looking good. I have a couple of tweaks: : --- Makefile.orig Wed May 24 09:46:49 2023 : +++ Makefile Wed May 24 12:31:45 2023 : @@ -1,6 +1,7 @@ : COMMENT = unicode text to postscript converter : : -DISTNAME = u2ps-1.2 : +V = 1.2 : +DISTNAME = u2ps-$V might as well use a variable for the version number here, so it only needs changing in one place when updating. : CATEGORIES = print : HOMEPAGE = https://github.com/arsv/u2ps/ : MAINTAINER = Alexander Arkhipov <a...@manpager.net> : @@ -8,7 +9,7 @@ MAINTAINER = Alexander Arkhipov <a...@manpager.net> : # GPLv3 : PERMIT_PACKAGE = Yes : : -MASTER_SITES = https://github.com/arsv/u2ps/releases/download/1.2/ : +MASTER_SITES = https://github.com/arsv/u2ps/releases/download/$V/ : : WANTLIB += c : : @@ -16,7 +17,8 @@ RUN_DEPENDS = print/ghostscript/gnu : : USE_GMAKE = Yes : CONFIGURE_STYLE = simple : -CONFIGURE_ARGS = --cc=cc --prefix=${TRUEPREFIX} --mandir={TRUEPREFIX}/man : +CONFIGURE_ARGS = --prefix=${TRUEPREFIX} \ : + --mandir=${TRUEPREFIX}/man I've removed --cc because the configure script respects CC in the environment so it's set correctly automatically (generally ports should allow overriding the compiler e.g. "make CC=egcc" or whatever). And generally we prefer to split up CONFIGURE_ARGS by line. Your Makefile missed $ from mandir, I've added that. : ALL_TARGET = default : : .include <bsd.port.mk> : Updated version attached, any OKs to import? (or if someone else would like to commit it's OK sthen@).
u2ps.tgz
Description: application/tar-gz
