On Mon, May 15, 2023 at 04:47:31PM -0600, Ashlen wrote:
> I tested the update briefly and it works. Noticed some errors in `make
> test` about rand(), strcat(), and sprintf(), but I'm unsure what to do
> about those.
These are warnings intended to help developers avoid some APIs deemed
too dangerous for use in OpenBSD. If you're "only" a porter of software,
it is more likely that you will break things by "fixing" those, so it's
best left alone. If it only shows up as part of 'make test', it won't
matter much.
> Adding boost_atomic-mt to WANTLIB was necessary to pass
> port-lib-depends-check.
I haven't tested yet but if port-lib-depends-check tells you to add it,
it's probably right.
I'll look more closely and will likely commit tomorrow. One thing (I can
fix this before commit):
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/net/i2pd/pkg/PLIST,v
> retrieving revision 1.10
> diff -u -p -r1.10 PLIST
> --- pkg/PLIST 26 Feb 2023 07:51:45 -0000 1.10
> +++ pkg/PLIST 15 May 2023 22:28:46 -0000
> @@ -131,6 +131,7 @@ share/examples/i2pd/certificates/reseed/
> @sample ${LOCALSTATEDIR}/lib/i2pd/certificates/reseed/acetone_at_mail.i2p.crt
> @owner
> @group
> +share/examples/i2pd/certificates/reseed/arnavbhatt288_at_mail.i2p.crt
The new cert needs a @sample line like all the other certs in PLIST.
This way users can modify or remove them and the next update won't
overwrite the modifications:
@owner _i2pd
@group _i2pd
@sample
${LOCALSTATEDIR}/examples/i2pd/certificates/reseed/arnavbhatt288_at_mail.i2p.crt
@owner
@group
> share/examples/i2pd/certificates/reseed/creativecowpat_at_mail.i2p.crt
> @owner _i2pd
> @group _i2pd
