Hi. textproc/zathura will consistently SIGSEGV and dump a core file when
I hit <TAB> to view the table of contents. I examined the core file and
found that this is due to an invalid read in girara_node_free,
referenced in this issue and fixed in the commit following it.

https://git.pwmt.org/pwmt/girara/-/issues/17
https://git.pwmt.org/pwmt/girara/-/commit/6926cc1234853ccf3010a1e2625aafcf462ed60e

Bumping x11/girara to 0.4.0 fixes the issue. I added SEPARATE_BUILD=Yes
while here since that works.

Any feedback? I kept the diff minimal, but am open to suggestions.

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/girara/Makefile,v
retrieving revision 1.27
diff -u -p -r1.27 Makefile
--- Makefile    28 Dec 2022 22:56:14 -0000      1.27
+++ Makefile    25 Apr 2023 22:13:00 -0000
@@ -1,5 +1,5 @@
 COMMENT =      user interface library from pwmt
-DISTNAME =     girara-0.3.8
+DISTNAME =     girara-0.4.0
 
 SHARED_LIBS += girara-gtk3               1.2 # 3.1
 
@@ -33,5 +33,7 @@ TEST_DEPENDS =        devel/check
 TEST_FLAGS +=  VERBOSE=1
 TEST_FLAGS +=  HOME=${WRKDIR}
 TEST_IS_INTERACTIVE =X11
+
+SEPARATE_BUILD =       Yes
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/x11/girara/distinfo,v
retrieving revision 1.15
diff -u -p -r1.15 distinfo
--- distinfo    28 Dec 2022 22:56:14 -0000      1.15
+++ distinfo    25 Apr 2023 22:13:00 -0000
@@ -1,2 +1,2 @@
-SHA256 (girara-0.3.8.tar.xz) = UXBiKODIIv8tMgkCnhQh6cFT7CAiemo8Z4V3Bipkg/w=
-SIZE (girara-0.3.8.tar.xz) = 60664
+SHA256 (girara-0.4.0.tar.xz) = zq/Qpq7VCtgyunZuxinx6jZmgcFfj6coqPVUGMOdyQE=
+SIZE (girara-0.4.0.tar.xz) = 60804

Reply via email to