On 2023/04/16 10:20, Joel Knight wrote: > On Sat, Apr 15, 2023 at 6:47 AM Stuart Henderson <s...@spacehopper.org> wrote: > > > > On 2023/04/15 13:45, Antoine Jacoutot wrote: > > > > > > Hi. > > > > > > A few things: > > Thanks, both, for the review. New tarball attached. > > py-awscrt: > > - Put a comment on USE_NOEXECONLY > - Switched MODPY_SETUPTOOLS -> MODPY_PYBUILD > - Added FLAVOR* > - Updated plist > - Removed ONLY_FOR_ARCHS > - Two new patch files included which allow building on arm64 > > awscliv2: > > - Bumped py-prompt_toolkit max version in RUN_DEPENDS > - Removed the patch-pyproject_toml patch file altogether since the > prompt-toolkit version bump upstream is now satisfied by the version > in ports > - Switched from DISTNAME to PKGNAME (default DISTNAME is sane) > - Set PKGNAME base to ‘awscli’ (I like this and agree with the 'better > discoverability' comment) > - Added @comment is-branch > - Got rid of $V > - Did not do the FLAVOR* changes > - Removed ONLY_FOR_ARCHS > > > > - if llvm is installed, the wrong ar is used by py-awscrt > > > -- CMAKE_AR found: /usr/local/bin/llvm-ar > > > > This is because it's not using standard ports build arguments for > > cmake as would be used by the cmake module (there are a bunch of > > CONFIGURE_ARGS lines to override various detected paths and other > > settings). > > > > The cc command lines are hidden in the output but I bet they are not > > using proper CFLAGS etc too. > > > > Not sure the best way to deal with this, but ideally it would use > > things from cmake.port.mk directly somehow rather than having to > > replicate and sync when things change.. > > When building s2n, one of the vendored deps in awscrt, cmake finds > /usr/local/bin/llvm-ar. I don’t know why it's preferring that over > what's in base. What are the implications of that?
It is finding that because it's not using the CONFIGURE_ARGS that are normally passed from cmake.port.mk to cmake. The implications are that 1) it will randomly fail in bulk builds and 2) there are probably some other things which are setup by cmake.port.mk which are also missing.
