For new cpan ports I'd generally be happier to use category/p5-CPAN-Module-Name with the same caps/dashes/underscores as upstream to make it easier to find them in the tree. That's usually what's done for existing cpan ports in the tree too. (Exception for App::SomeName which provide a standalone application that's probably better as plain 'somename').

--
 Sent from a phone, apologies for poor formatting.

On 7 March 2023 13:31:56 Johannes Thyssen Tishman <johan...@thyssentishman.com> wrote:

2023-03-07T08:46:59Z Stuart Henderson <s...@spacehopper.org>:

On 2023/03/06 20:44, Johannes Thyssen Tishman wrote:
Hi,

im happy to share my first two ports: p5-graph-easy and p5-graph-easy-svg.

Graph::Easy lets you convert or render graphs as ASCII, HTML, SVG
or via Graphviz. See the manual[1] for examples.

The second port is really just an optional dependency to add SVG
support. I initially though that it makes more sense to pack them
together but I don't know if this is a good practice and I couldn't
figure out how to do it with the Makefile system. Any feedback on this
would be appreciated. Additionally I chose the math category since
graphviz is also there. I believe they belong in graphics, but I left
them in math for consistency.

Please see ports attached. Comments are welcome :)

Kind regards,
Johannes

[1] http://bloodgate.com/perl/graph/manual/index.html

Generally looks pretty good, here are some quick comments.

Please use 8 column tabs, don't list "perl5" in categories yourself
(it's set automatically), and lowercase for the start of COMMENT
in the svg one.

Thanks for the feedback, I'll make the corrections.

The directory names don't match the package names
(e.g. p5-graph-easy-svg vs p5-Graph-Easy-As_svg), it's better if
they do match (I'd rename the directories not set package names
for this).

I noticed that folders can be named all lower case even for package names with caps. What's the case for dashes and underscores? Is it also flexible?

Otherwise I suppose I'd have to name the second port p5-graph-easy-as_svg which I find quite awkward (e.g. when querying with pkg_info)

Separate ports for the separate cpan modules is right, bundling them
together will be awkward.

Reply via email to