On Mon, Feb 13, 2023 at 10:12:15PM +0100, Christian Weisgerber wrote: > Theo Buehler: > > > x11/chbg gtk/gnome stuff [-Wint-conversion] > > X11 stuff, really. > > This code uses gdk_atom_intern() to construct an atom that it passes > to various X*Property() functions. Except that gdk_atom_intern() > returns a pointer to a GdkAtom structure, which is most certainly > not an X11 Atom. As is, the code calls X*Property() with what > amounts to random garbage. Maybe the calls to gdk_atom_intern() > can be replaced with XInternAtom(), but I don't really know anything > about X11 programming. There is also the slight risk that fixing > nonfunctioning code might end up breaking something. > > It appears chbg started in 1999 for GTK1 and was barely moved over > to GTK2. It was last touched in 2006. We could just remove the > port; it's gone from FreeBSD and Debian.
Not that I tried very hard, but it doesn't seem to work on -current. $ chbg /tmp/IMG_2084.jpg removing picture "/.1/upload/pic/MANGA6.JPG" from list removing picture "/.1/upload/pic/MANGA3.JPG" from list removing picture "/.1/upload/pic/MANGA4.JPG" from list The program 'chbg' received an X Window System error. This probably reflects a bug in the program. The error was 'BadMatch (invalid parameter attributes)'. (Details: serial 230 error_code 8 request_code 70 minor_code 0) I'm ok with removing it. > Missing from your list: > > | x11/eterm [-Wint-conversion] > > That mixes pointer and integer semantics in such a way that I > couldn't figure out what it was even intended to do. That one, too.
