On Mon, Feb 06, 2023 at 08:10:45PM +0100, Gonzalo L. Rodriguez wrote:
> Update for Suricata to 6.0.10:
> OK? Comments?

>  SHARED_LIBS +=       htp                       0.0 # 2.0

New library has new symbols, we need at least a minor bump.

$ /usr/src/lib/check_sym /usr/local/lib/libhtp.so.0.0 
fake-amd64/usr/local/lib/libhtp.so.0.0
/usr/local/lib/libhtp.so.0.0 --> fake-amd64/usr/local/lib/libhtp.so.0.0
Dynamic export changes:
added:
        htp_gzip_decompressor_decompress
        htp_gzip_decompressor_destroy

PLT added:
        htp_gzip_decompressor_decompress
        htp_gzip_decompressor_destroy

> -lib/python${MODPY_VERSION}/site-packages/suricata_update-${SUPDATE_V}-py${MODPY_VERSION}.egg/suricata/update/version.py
> +lib/suricata/python/suricata/update/version.py

I see that upstream has changed that.  But our portcheck complains
that python files should be in version directory.

Python module without compiled version, consider using ${MODPY_BIN} 
${MODPY_LIBDIR}/compileall.py: lib/suricata/python/suricata/update/version.py

Should we generate the .pyc files?

I found some '#! /usr/bin/env python' scripts in the code.
We have not python, but this link:
/usr/local/bin/python3 -> python3.10
Should we patch ot to ''#! /usr/bin/env python3' ?
Or /usr/local/bin/python3 ?

I am not a python expert, just wondering.

bluhm

Reply via email to