On 2023/01/24 18:37:55 +0000, Job Snijders <j...@openbsd.org> wrote:
> Hi all,
> 
> Attached is a port of textproc/grepcidr3, this fork of grepcidr has a
> few command line options that the original lacks, such as -D:
> 
>     $ echo 10.1.1.0/24 | grepcidr3 -D 10.1.1.1
>     10.1.1.0/24
> 
> I added 2 patches:
>    * rename the utility to 'grepcidr3' (in order to avoid naming collisions)
>    * add pledge("stdio rpath", NULL) in main().
> 
> OK?

there's a CVS directory still left in pkg/

needs a little tweak to respect CFLAGS and it's also custom to add a
comment marker for stuff using pledge.

--- Makefile.orig       Tue Jan 24 19:55:47 2023
+++ Makefile    Tue Jan 24 19:56:16 2023
@@ -11,7 +11,10 @@
 # BSD 2-Clause and GPLv2+
 PERMIT_PACKAGE=        Yes
 
+# uses pledge()
 WANTLIB += c
+
+MAKE_FLAGS +=  CFLAGS="${CFLAGS}"
 
 NO_TEST=       Yes


could also set the version to something like 0.0pl20230107 since
upstream hasn't tagged any version, even if it says 'grepcidr 3.0'
with -V.  would avoid setting EPOCH if upstream starts tagging with
something lower than 3.0.

otherwise the port looks OK for me.

Don't know much about the history of the tool, there's any specific
reason to not just upgrade the existing textproc/grepcidr to this
fork instead?

Reply via email to