On 2023/01/21 01:15, aisha wrote:
> On 23/01/17 11:22AM, Stuart Henderson wrote:
> > On 2023/01/17 11:39, Landry Breuil wrote:
> > > Le Sat, Jan 14, 2023 at 07:59:36AM -0500, aisha a ?crit :
> > >
> > > i think the readme needs some fmt -w love, dont remember if it should be
> > > 80 or 72 but the lines are definitely too wide.
> > >
>
> Now with 1000% more formatting but still 3 lines are out of 80 chars.
> But they are code lines so I don't want to split them up further.
>
> > > why not @sampling the config files ? because they'd override the default
> > > ones provided by nginx & prosody ?
> >
> > It wouldn't get installed at all if you install nginx first then jitsi.
> > And if you install jitsi first then nginx it will override.
> >
> > For nginx (I don't know prosody at all) it might be better to provide
> > (and @sample somewhere) a partial nginx config section to use with
> > "include". Or just include the block in pkg-readme, which is what
> > most ports do.
> >
>
> I took this advice and now I've included just the "server { ... }" part
> of the nginx config in the README, and only installing the prosody example
> config as a file. Prosody isn't that widely used by newbie sysadmins (e.g. me)
> so having a full fledged configuration is helpful.
>
> Attached port with fixes.
That looks better to me. OK sthen@
