On Sun, Jan 15, 2023 at 08:01:19PM +0100, Rafael Sadowski wrote:
> On Sun Jan 15, 2023 at 07:20:40PM +0100, Caspar Schutijser wrote:
> > On Sun, Jan 15, 2023 at 04:25:07PM +0100, Rafael Sadowski wrote:
> > > On Sun Jan 15, 2023 at 02:19:11PM +0100, Caspar Schutijser wrote:
> > > > Hi,
> > > > 
> > > > Any interest in this port? I adapted the x11/kde-applications/svgpart
> > > > port for this. Comments or OKs?
> > > > 
> > > > Caspar
> > > > 
> > > > ----
> > > > Markdown Viewer KPart is a small KDE KPart component to display
> > > > Markdown files in Kate and in any other KDE application which uses
> > > > the KPart system.
> > > > ----
> > > 
> > > 
> > > OK but please remove PKGNAME. I see no good reason to do that, do you?
> > 
> > Now that you mention it, yes, it probably makes sense to remove it.
> > However, I copied it from svgpart and I wonder whether it makes sense
> > to have it there then. What do you think? Not a big deal for me though.
> > I'll remove it from markdownpart.
> 
> Thanks. For a long time svgpart was a part of x11/kde4 so we added kf5
> prefix/suffix for some kde ports.
> 
> > 
> > Btw, I noticed that the Makefile in x11/kde-applications has some more
> > structure than other similar Makefiles; is the below diff OK to hook
> > it up or should I put it in another spot in this file? As you can see
> > I set CATEGORIES = textproc in markdownpart's Makefile so I figured I'd
> > add such a section here too but if you have any other preference, let
> > me know.
> 
> OpenBSD ports category textproc is right. KDE category, see blow.
> 
> > 
> > Caspar
> > 
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/x11/kde-applications/Makefile,v
> > retrieving revision 1.75
> > diff -u -p -r1.75 Makefile
> > --- Makefile        20 Dec 2022 18:34:20 -0000      1.75
> > +++ Makefile        15 Jan 2023 18:15:43 -0000
> > @@ -165,6 +165,9 @@
> >       SUBDIR += print-manager
> >       SUBDIR += sweeper
> >  
> > +     # textproc
> > +     SUBDIR += markdownpart
> > +
> 
> markdownpart is part of kde utilities
> (https://invent.kde.org/utilities/markdownpart)

Ah, right. Good to know. Then here's an updated diff, just to be sure.
OK?

Caspar


Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/kde-applications/Makefile,v
retrieving revision 1.75
diff -u -p -r1.75 Makefile
--- Makefile    20 Dec 2022 18:34:20 -0000      1.75
+++ Makefile    15 Jan 2023 19:57:39 -0000
@@ -162,6 +162,7 @@
      SUBDIR += kteatime
      SUBDIR += ktimer
      SUBDIR += kwalletmanager
+     SUBDIR += markdownpart
      SUBDIR += print-manager
      SUBDIR += sweeper
 
@@ -257,7 +258,6 @@
      # kosmindoormap
      # kpmcore
      # kpublictransport
-     # markdownpart
      # partitionmanager
 
 

Reply via email to