On 2023/01/13 05:00:52 +0100, Mattia Chiozzi <mat...@chiozzi.cc> wrote: > Hi, > a new version has just been released which addressed the CFLAGS issue, so I am > attaching the new tarball. > > On Fri, Jan 13, 2023 at 01:26:11AM +0100, Mattia Chiozzi wrote: > > Hi, > > I can't believe I got so many things wrong, this was my first port. > > Sorry for the mistakes and thank you for all the corrections.
No problem :)
it was a solid first submission, the things i noted were minor (and
easy to miss ;-)
Regarding the updated tarball, I think we can do still a couple of
tweaks.
- with this new version there's no need to tweak the CFLAGS anymore.
- It needs PREFIX="${TRUEPREFIX}" (or DESTDIR='', whichever your
prefer) otherwise installs the data in the wrong
directory. (appending DESTDIR twice.)
This is not an issue with upstream' makefile. During `make fake'
the ports infrastructure prefixes DESTDIR to PREFIX (see TRUEPREFIX
in bsd.port.mk(5)) so, depending on how makefiles are laid,
sometimes you need to neuter this by passing an empty DESTDIR or
changing PREFIX in FAKE_FLAGS.
- set NO_TESTS=Yes. I forgot about this in the previous mail. Not a
big deal however.
Here's a diff against your Makefile and an updated tarball that's
still ok op@ to import.
(looking forward to play with tiramisu too!)
Thanks,
Omar Polo
--- Makefile.orig Fri Jan 13 11:43:16 2023
+++ Makefile Fri Jan 13 11:53:30 2023
@@ -16,10 +16,9 @@
LIB_DEPENDS = graphics/imlib2
-CFLAGS += -I${LOCALBASE}/include \
- -I${X11BASE}/include \
- -I${X11BASE}/include/freetype2
+FAKE_FLAGS = MANPREFIX="${TRUEPREFIX}/man" \
+ PREFIX="${TRUEPREFIX}"
-FAKE_FLAGS = MANPREFIX="${TRUEPREFIX}/man"
+NO_TESTS = Yes
.include <bsd.port.mk>
xnotify.tar.gz
Description: GNU Zip compressed data
